Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test #1326

Merged
2 commits merged into from Jan 13, 2019
Merged

Random test #1326

2 commits merged into from Jan 13, 2019

Conversation

JoshDreamland
Copy link
Member

Add a test for the random() function. Also add expect() methods to GTest. (Expect to merge both commits using a rebase).

@codecov
Copy link

codecov bot commented Jul 21, 2018 •
edited

Codecov Report

Merging #1326 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   16.74%   16.92%   +0.18%     
==========================================
  Files         164      164              
  Lines       17095    17095              
==========================================
+ Hits         2862     2893      +31     
+ Misses      14233    14202      -31
Impacted Files Coverage Δ
.../SHELL/Universal_System/Extensions/GTest/include.h 100% <100%> (ø) ⬆️
ENIGMAsystem/SHELL/Universal_System/mathnc.h 98.3% <0%> (+1.69%) ⬆️
.../SHELL/Universal_System/Extensions/GTest/GTest.cpp 73.68% <0%> (+31.57%) ⬆️
ENIGMAsystem/SHELL/Universal_System/random.cpp 83.78% <0%> (+64.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950036a...6160647. Read the comment docs.

@RobertBColton RobertBColton added Universal System Resource storage and other logic universal to more than one system or extension. Continuous Integration Related to CI services utilized and the related scripts. labels Jul 25, 2018
@RobertBColton
Copy link
Contributor

RobertBColton commented Aug 28, 2018 •
edited

Are you going to actually test irandom or not which was my issue (not random) now that we've made the CI not act like a hog? Please do and I believe you will find the issue.

@JoshDreamland
Copy link
Member Author

Remind me tonight, I guess.

@ghost ghost merged commit e3acf06 into master Jan 13, 2019
@RobertBColton RobertBColton deleted the RandomTest branch January 13, 2019 11:38
@RobertBColton
Copy link
Contributor

This is good for now but @JoshDreamland still needs to add irandom to the test!

@JoshDreamland JoshDreamland restored the RandomTest branch January 22, 2019 00:23
@RobertBColton RobertBColton deleted the RandomTest branch July 8, 2023 21:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Continuous Integration Related to CI services utilized and the related scripts. Universal System Resource storage and other logic universal to more than one system or extension.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshDreamland @RobertBColton