Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High score screen doesn't work like expected #1982

Open
sharkwouter opened this issue Apr 19, 2020 · 9 comments
Open

High score screen doesn't work like expected #1982

sharkwouter opened this issue Apr 19, 2020 · 9 comments
Labels
Good First Issue Something considered solvable by a novice contributor.

Comments

@sharkwouter
Copy link

sharkwouter commented Apr 19, 2020

I ran into this with the game example keep-left from this website: http://rupert.id.au/tutorials/gamemaker/examples.php

I noticed the following differences between the scoreboard in Game Maker 6:

  • You're not able to enter you name
  • The message "press to close" isn't shown
  • The background configured for the scoreboard is not being shown
  • The configured colors for the scoreboard are ignored
  • The font used doesn't match the configured one
  • Scores are not saved, not even during a single session

Also the following, but I personally don't care about these:

  • No border is shown
  • The scoreboard is not a separate window and instead covers the whole screen

I was able to reproduce this on both the example and a new example. I was able to reproduce this for the platforms Windows, Linux and SDL.

Here are some screenshots for comparison. I ran the original exe file with wine as well:
Screenshot from 2020-04-19 23-03-26
Screenshot from 2020-04-19 23-02-33

@sharkwouter
Copy link
Author

There was an attempt to fix this with #1973

@RobertBColton
Copy link
Contributor

RobertBColton commented Jun 23, 2020

I believe this has to do with ENIGMA not having the dialog from #1973 which was deprecated by GMSv1.4.

So we implemented highscore_show using draw_highscore which is in fact still a supported function in GMS2.
https://docs2.yoyogames.com/source/_build/3_scripting/4_gml_reference/drawing/text/draw_highscore.html

@fundies fundies added the Good First Issue Something considered solvable by a novice contributor. label Mar 15, 2021
@le-incroyable1-dev
Copy link

Hi ! I'm new here. This is my first time contributing to open source. Any help on how I can help fix the issue ??

@RobertBColton
Copy link
Contributor

Have you installed ENIGMA yet? That's a good place to start.
https://enigma-dev.org/download.htm

Once you have ENIGMA installed it is very easy to change the source files and they will automatically be recompiled. ENIGMA is divided into different systems (enigma-dev/ENIGMAsystem/SHELL/) for platforms, audio, and graphics. There is a universal system as well where the highscore functions are implemented.
https://github.com/enigma-dev/enigma-dev/blob/master/ENIGMAsystem/SHELL/Universal_System/highscore_functions.cpp

@k0T0z
Copy link
Contributor

k0T0z commented Apr 10, 2022

I'm working on this issue so I tried to run the game in the example (keep-left.gm6) in LateralGM but it refuses to run but returns -1073741819 can you help on this? @RobertBColton

@RobertBColton
Copy link
Contributor

RobertBColton commented Apr 10, 2022

Any time the game returns a large negative number it's generally a crash. You can build the game in debug mode, install GDB if it's not already, then following the debugging guide I wrote.

https://enigma-dev.org/docs/Wiki/Debugging

This will help you find source and line number of what is causing the crash.

@k0T0z
Copy link
Contributor

k0T0z commented Apr 13, 2022

okay I followed those steps but the problem is it returns a large negative integer on debugging also, the other problem is when I looked at the directory where it build the executable to, I didn't find any executable so when running (gdb C:/msys64/tmp/egm3870279439369633378.exe) it outputs the below paragraph:

C:\Users\saifs>gdb C:/msys64/tmp/egm518996892078311101.exe
GNU gdb (GDB) 7.6.1
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "mingw32".
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/...
C:/msys64/tmp/egm518996892078311101.exe: No such file or directory.
(gdb)

is the problem because I'm using mingw32 on a 64-bit machine or anything else? @RobertBColton

@JoshDreamland
Copy link
Member

Does the command work if you ls or stat that file instead? You may need to use the more Unix-like /c/ representation, rather than the Windows C:/, depending on your terminal environment.

@k0T0z
Copy link
Contributor

k0T0z commented Apr 13, 2022

thanks @JoshDreamland, it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Something considered solvable by a novice contributor.
Projects
None yet
Development

No branches or pull requests

6 participants