Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Update 2020 #2178

Closed
wants to merge 40 commits into from
Closed

Dialog Update 2020 #2178

wants to merge 40 commits into from

Conversation

time-killer-games
Copy link
Contributor

@time-killer-games time-killer-games commented Dec 23, 2020

TODO:

  • Cocoa
  • xlib

@time-killer-games
Copy link
Contributor Author

@JoshDreamland I have it building and running OK in Run/Debug mode. However compile mode does this: https://pastebin.com/mGm6GHVb

No idea how I'm supposed to fix this. Do you?

@time-killer-games
Copy link
Contributor Author

time-killer-games commented Dec 24, 2020

@JoshDreamland I still haven't figured out a way to get rid of those errors, despite fixing a few imperfections i found and resolved in the more recent commits since my last comment. However, I do have the Run Mode executable still working as mentioned before, which i retrieved out of my msys2 tmp folder and have uploaded in this post below.

DialogModule.zip

You can test that file with WINE if you want since you probably don't have access to Windows easily, however, the input box dialogs don't show up in WINE and are skipped since they require API's that the WINE developers have not implemented yet, probably due the fact it relies on a System32 ActiveX COM object which is not portable. This is not a problem on Windows, obviously. Everything else should work in WINE out of the box.

I really don't get why run and debug mode work, but compile does not.

@JoshDreamland
Copy link
Member

Versioning the binary as text has all the same problems as versioning it as a binary. Changes to it clog up the commit history. You could split a single method into two and the entire file would be different.

Also, as text, this change is bigger than the entire remainder of the engine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants