Fix GTest extension build fails on installing it by building from source on windows #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBColton
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
Looks good, glad they got back to me about this!
msys2/MINGW-packages#5113
|
cool, thanks robert |
k0T0z
changed the title
|
I like the dynamic approach more than the static one so let's close this as it's not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2338
GTest extension must be installed using
pacman -S mingw-w64-x86_64-gtestto be working correctly with the currentENIGMAsystem/SHELL/Universal_System/Extensions/GTest/Makefile, but if you installed GTest with another way (building it from source and copy-paste files), it won't work because you will need the.dllfile for linking it dynamically which is not provided when you build gtest from source, you only got.afiles.Using pacman or building from source gives you
.afiles, which you can link statically to your exe and this PR provides that change.