Remove React.createFactory call on new React versions since React thr… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows warning about no render method defined when component is wrapped with createFactory Warning: Component(...): No `render` method found on the returned component instance: you may have forgotten to define `render` in your component or you may have accidentally tried to render an element whose type is a function that isn't a React component.
|
@rikukissa 100% sure about that? When I was testing it earlier the rendering didn't work without that... |
|
React.createFactory is a necessary wrapper for those not using JSX - however, the module consumer should be responsible for calling createFactory if they need to. Otherwise those using JSX will run into problems. Per Facebook, exporting factories is an anti-pattern that should be avoided, the class should be exported instead. |
|
Yeah, when used without JSX everything surely works fine with createFactory, but with JSX you'll get the error I mentioned earlier. So it would probably be logical to export the barebones version of the component and let non-JSX users wrap the component with createFactory |
quantizor
pushed a commit
that referenced
this pull request
Sep 21, 2015
Remove React.createFactory call on new React versions since React thr…
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ows warning about no render method defined when component is wrapped with createFactory
Warning: Component(...): No
rendermethod found on the returned component instance: you may have forgotten to definerenderin your component or you may have accidentally tried to render an element whose type is a function that isn't a React component.