Fix for importing and exporting matrix field settings #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2015 14:38
…get lost. Changed the fieldservice so that blocktypes are added to the matrix field settings, and then stored together with the matrix field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem when exporting and importing fields of matrix blocks.
Settings of these fields were not included in the export, and also not imported.
I have made one function to extract field attributes (including settings) for both types of fields in the fields service. Settings are now also imported for matrix block fields.
In addition there was an issue with data getting lost when importing block types. I've modified the fields service so that imported block types are added to the settings of the matrix field. They are then stored together with the matrix field by the MatrixFieldType onAfterSave function.