Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating macros for validator syntax extenstion #689

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Creating macros for validator syntax extenstion #689

merged 6 commits into from
Dec 10, 2020

Conversation

PumpkinSeed
Copy link
Contributor

No description provided.

@Cashmaney
Copy link
Member

Very cool! @reuvenpo any comments?

reuvenpo
reuvenpo reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@reuvenpo reuvenpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry, i forgot to reply to this after seeing a notification about your PR this morning. I only have one comment left :)

cosmwasm/packages/wasmi-runtime/src/macros.rs Outdated Show resolved Hide resolved
cosmwasm/packages/wasmi-runtime/src/macros.rs Outdated Show resolved Hide resolved
@PumpkinSeed
Copy link
Contributor Author

I added the changes. :)

@reuvenpo
Copy link
Contributor

reuvenpo commented Dec 10, 2020 •
edited
Loading

I looked at the repo at your last commit, and went ahead and applied some more changes.
I figured it would take less time than explaining what i wanted you to do 😅
Please review my last two commits, and let me know if you have any questions about what i did.
After you've reviewed them, we'll merge them to our repository 😄

reuvenpo
reuvenpo approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@reuvenpo reuvenpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @PumpkinSeed ! 😄

@reuvenpo reuvenpo merged commit bc7d8c4 into scrtlabs:dev/v1.1.x Dec 10, 2020
@reuvenpo reuvenpo mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuvenpo reuvenpo reuvenpo approved these changes

@assafmo assafmo Awaiting requested review from assafmo

@Cashmaney Cashmaney Awaiting requested review from Cashmaney

@toml01 toml01 Awaiting requested review from toml01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PumpkinSeed @Cashmaney @reuvenpo