Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExternalConsultant & basic logic for it #241

Merged
merged 9 commits into from
Dec 7, 2022
Merged

Add ExternalConsultant & basic logic for it #241

merged 9 commits into from
Dec 7, 2022

Conversation

rnudb
Copy link
Contributor

@rnudb rnudb commented Nov 15, 2022

No description provided.

@rnudb rnudb linked an issue Nov 15, 2022 that may be closed by this pull request
filter access by source #206
Closed
@rnudb rnudb force-pushed the 206-filter-access-by-source branch 3 times, most recently from 04e0a6b to bbeb015 Compare November 17, 2022 14:21
rnudb
rnudb commented Nov 17, 2022
View reviewed changes
interview/views.py Outdated Show resolved Hide resolved
rnudb
rnudb commented Nov 17, 2022
View reviewed changes
ref/models.py Outdated Show resolved Hide resolved
@rnudb rnudb force-pushed the 206-filter-access-by-source branch from 84cc591 to 23b60c4 Compare November 18, 2022 13:28
@rnudb rnudb marked this pull request as ready for review November 18, 2022 13:30
bport
bport requested changes Nov 21, 2022
View reviewed changes
ref/models.py Show resolved Hide resolved
ref/models.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
@rnudb rnudb force-pushed the 206-filter-access-by-source branch from 7593082 to f9423d6 Compare November 21, 2022 16:52
bport
bport requested changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@bport bport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some test to ensure all work as expected (don't need to have a test for each view)

But at least :
Test external user access on a page with right, on a source page not allow, external without source associated to him.

ref/models.py Outdated Show resolved Hide resolved
ref/models.py Outdated Show resolved Hide resolved
ref/models.py Outdated Show resolved Hide resolved
@bport bport added this to the v1.17 milestone Nov 22, 2022
@rnudb rnudb force-pushed the 206-filter-access-by-source branch 2 times, most recently from 9a5de79 to a7b2810 Compare November 22, 2022 14:05
@rnudb rnudb force-pushed the 206-filter-access-by-source branch from a7b2810 to d74e793 Compare November 22, 2022 14:15
ArnaudChirat
ArnaudChirat requested changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@ArnaudChirat ArnaudChirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add middleware to check if user is valid.

  • If external is correct

interview/models.py Outdated Show resolved Hide resolved
interview/views.py Outdated Show resolved Hide resolved
@rnudb rnudb force-pushed the 206-filter-access-by-source branch from c0678b7 to dc9740e Compare November 25, 2022 09:17
ArnaudChirat
ArnaudChirat requested changes Nov 29, 2022
View reviewed changes
interview/tests.py Show resolved Hide resolved
@rnudb rnudb force-pushed the 206-filter-access-by-source branch from c9f0927 to 19ac3c0 Compare November 29, 2022 12:55
@bport bport merged commit aabb036 into master Dec 7, 2022
@bport bport deleted the 206-filter-access-by-source branch December 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bport bport bport requested changes

@ArnaudChirat ArnaudChirat ArnaudChirat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

filter access by source
3 participants
@rnudb @bport @ArnaudChirat