litedram_gen: Don't block user port with no CPU #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change e52ece0 blocks access to user ports prior to dram init. As noted in enjoy-digital#286 (comment) this is a problem for cpu-less designs, since the initial memtest requires the user port. Instead enable the user port unconditionally in that case.
|
Thanks @mkj, this is indeed an issue with CPU-less controllers. But even in this case, blocking the other ports could be necessary so the fix was probably not flexible enough. This is fixed a bit differently with 62abf9c that introduces a |
mkj
added a commit
to mkj/microwatt
that referenced
this pull request
Jan 14, 2022
Recent litedram gets stuck at memtest unless block_until_ready=False. (discussion in enjoy-digital/litedram#292) This change regenerates with latest litedram and litex 62abf9c ("litedram_gen: Add block_until_ready port parameter to control blocking behaviour.") add2746a ("tools/litex_cli: Rename wb to bus.") Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change e52ece0 blocks access to user ports prior to dram init.
As noted in #286 (comment) this is a problem for cpu-less designs, since the initial memtest requires the user port.
Instead enable the user port unconditionally in that case.