Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16-bits, RGB565 FB support in simple-framebuffer #1053

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

rdolbeau
Copy link
Contributor

This adds support for a 16-bits (RGB565) version of the framebuffer, the intent is to save on DRAM bandwidth (although that's probably only true if the DRAM interface is 16 bits or lower, as the code doesn't load multiple pixels at once if the memory interface is wider than the pixel depth).

@rdolbeau
Copy link
Contributor Author

my bad, the code does load multiple pixels at once, it's 'hidden' in the stream.Converter if I understand correctly.

@rdolbeau
Copy link
Contributor Author

force-pushed a missing bits in the DTS, the reserved memory was still 4 bytes per pixel.

Copy link
Owner

@enjoy-digital enjoy-digital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdolbeau! This looks good and has been merged.

@enjoy-digital enjoy-digital merged commit 6d317d0 into enjoy-digital:master Oct 8, 2021
@enjoy-digital
Copy link
Owner

enjoy-digital commented Oct 8, 2021

@rdolbeau: I just changed depth parameter to format in f508b13. This should be more explicit and will allow supporting more video formats in the future. I hope it's fine for you?

@rdolbeau
Copy link
Contributor Author

rdolbeau commented Oct 8, 2021

Fine with me :-)
(but those two are the only two supported by Linux' simple-framebuffer, so other formats would need a different DTS entry / driver to get Linux support ; other OSes - or lack thereof ! - may differ of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants