Change the default IRQs. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better error messages. * Search correct directories; - XXX/Vivado/<version> - XXX/<version>/ISE_DS/
|
@stffrdhrn - Can you give this change a test? |
mithro
force-pushed
the
uart-irq-change
branch
from
21ab5bf
to
bb4a031
Compare
|
Adding a bunch of fixes.
|
|
And a datapoint why something like this is important - I just discovered we are using the same IRQ value for LiteEth and HDMI0 in the HDMI2USB-litex-firmware (before we changing the value). That now provides the helpful error message; |
* Reserve IRQ 0 to be used as a "non-maskable interrupt" (NMI) in the future. * Use IRQ 2 for the LiteX. This matches the standard mor1k config which connects the UART to IRQ 2. This change is needed for Linux running on LiteX as it gets grumpy with using IRQ 0 for anything other other than an NMI.
mithro
force-pushed
the
uart-irq-change
branch
from
7a019e4
to
56ef229
Compare
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve IRQ 0 to be used as a "non-maskable interrupt" (NMI) in the future.
Make it harder to define duplicate IRQs and provide better error messages when it happens.
Use IRQ 2 for the LiteX. This matches the standard mor1k config which connects the UART to IRQ 2.
This change is needed for Linux running on LiteX as it gets grumpy with using IRQ 0 for anything other other than an NMI.