Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change misleading comment about ModuleDoc. #668

Commits on Oct 6, 2020

  1. Change misleading comment.

    Not calling `ModuleDoc.__init__(self)` causes `duid` to be unset and exceptions like this:
    
    Traceback (most recent call last):
      File "mydesign.py", line 299, in <module>
        main()
      File "mydesign.py", line 292, in main
        generate_docs(soc, "build/"+target+"/documentation")
      File ".../litex/litex/litex/soc/doc/__init__.py", line 98, in generate_docs
        documented_region = DocumentedCSRRegion(
      File ".../litex/litex/litex/soc/doc/csr.py", line 80, in __init__
        docs = module.get_module_documentation()
      File ".../litex/litex/litex/soc/integration/doc.py", line 141, in gatherer
        return sorted(r, key=lambda x: x.duid)
      File ".../litex/litex/litex/soc/integration/doc.py", line 141, in <lambda>
        return sorted(r, key=lambda x: x.duid)
      File ".../litex/migen/migen/fhdl/module.py", line 136, in __getattr__
        raise AttributeError("'"+self.__class__.__name__+"' object has no attribute '"+name+"'")
    AttributeError: 'CDCUsbPHY' object has no attribute 'duid'
    fidergo-stephane-gourichon committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    321f50d View commit details
    Browse the repository at this point in the history