Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ffi conditional install on Windows platforms #160

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Remove ffi conditional install on Windows platforms #160

merged 4 commits into from
Sep 20, 2019

Commits on Sep 19, 2019

  1. Do not install ffi gem automatically on Windows platforms 

    We originally introduced this logic in #132 without understanding all
the implications.

Issue #158 raised a challenge with this approach.
    @sds
    sds committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    67845b0 View commit details
    Browse the repository at this point in the history

  2. Update change log

    @sds
    sds committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    c0dd089 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Display friendlier error message when ffi not installed

    @sds
    sds committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c0cc6f2 View commit details
    Browse the repository at this point in the history

  2. Bump gem version to 3.0.0 

    Given the removal of the extension logic that conditionally installed
the `ffi` gem on Windows platforms, this fundamentally changes the
assumptions around what the gem installs and thus its backwards
compatibility, hence necessitating a major version upgrade.
    @sds
    sds committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    f72bccc View commit details
    Browse the repository at this point in the history