This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: ensure uploaded media with spaces load in edit mode #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also backfills tests for the rest of `fileManager.getFileUrl` behavior
|
Sorry for the PR noise, I realized I had reused an old branch in #334 |
eyelidlessness
changed the title
lognaturel
approved these changes
Oct 16, 2021
| if ( subject.startsWith( '/' ) ) { | ||
| resolve( subject ); | ||
| } else if ( instanceAttachments && ( Object.prototype.hasOwnProperty.call( instanceAttachments, escapedSubject ) ) ) { | ||
| resolve( instanceAttachments[ escapedSubject ] ); | ||
| } else if ( instanceAttachments && ( Object.prototype.hasOwnProperty.call( instanceAttachments, subject ) ) ) { |
There was a problem hiding this comment.
I don’t believe the unescaped branch would ever be hit in normal browser-based usage. But it’s reasonable to leave in.
Merged
punkch
pushed a commit
to UNOPS/enketo-express
that referenced
this pull request
Nov 5, 2021
Also backfills tests for the rest of `fileManager.getFileUrl` behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also backfills tests for the rest of
fileManager.getFileUrlbehavior