This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Add codecov reporting #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh two notes:
|
eyelidlessness
changed the title
This was referenced Jan 12, 2022
eyelidlessness
force-pushed
the
refactor/enketo-webform/codecov-reporting
branch
2 times, most recently
from
fe7716f
to
8237976
Compare
This is implemented as an esbuild plugin because, mysteriously, the coverage preprocessor does not work when combined with esbuild.
Note: must be enabled on the repo by an admin
lognaturel
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of enketo/enketo#1030. Branched from #379 (see diff).
This change adds codecov reporting for PRs. We may choose to remove this after enketo/enketo#1030, but I do think it will be valuable to show that coverage stays the same or improves during the refactor.
I have verified this PR works with
No runtime code has been changed. But some additional tests were added.
What else has been done to verify that this works as intended?
A variety of experiments on working branches on my fork. As far as I can tell, it works as one would expect.
Why is this the best possible solution? Were any other approaches considered?
I'm not sure it's the best? But it seems to work and I'm not sure what value there would be in spending more time on it.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
In theory, identifying reduced coverage may help us assess risk for future changes. I certainly hope that will be the case for enketo/enketo#1030.
Do we need any specific form for testing your changes? If so, please attach one.
N/A.