This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Fix: Allow posts with underscores in the filename #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncodes
added a commit
that referenced
this pull request
Dec 27, 2012
* pr/11: Improve name of underscored slug example. Fix: Allow posts with underscores in the filename
|
We always use dashes in our slugs but there's no reason to force this. Thanks for the patch. Fixed in 0.0.6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized while using the new version on a site that had a couple of posts with underscores in the filename that they were not working anymore.
This is a regression I introduced when adding the timestamp functionality and went unnoticed. I fixed it and added tests to avoid this happening again.
I also changed it so that if you want to generate a post with underscores in it, they won't be removed by the generator when creating the default title.