-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask for confirmation when trying to close modal dialog with changed site configuration #4915
Comments
In onclick listener check if the form inside the dialog is "dirty". If it is, show the following confirmation message (similar to SaveBeforeCloseDialog): You have made changes to the form, do you want to apply them? The dialog itself should be masked when the confirmation is visible. Also, important - make this check a setting ("off" by default) inside the ModalDialog class so that we could turn it on for any modal dialog we want. Confirmation message should also be configurable, but the default text should be as stated above. |
…4915 Added ConfirmationDialog and config to ModalDialog.
…4915 Implemented `isDirty()` check in Forms. Added `isDirty()` check to `ModalDialog` before opening confirmation dialog.
…4915 Added possibility to close confirmation dialog without taking any action in original dialog.
…4915 Added border to the shadowed dialogs.
…4915 Replaced single instance of ConfirmationDialog and made him remove itself on close. Clicking outside the confirmation dialog will close it without action.
…4915 Update close action to close dialog without confirmation.
…4915 Added ConfirmationDialog and config to ModalDialog.
…4915 Implemented `isDirty()` check in Forms. Added `isDirty()` check to `ModalDialog` before opening confirmation dialog.
…4915 Added possibility to close confirmation dialog without taking any action in original dialog.
…4915 Added border to the shadowed dialogs.
…4915 Replaced single instance of ConfirmationDialog and made him remove itself on close. Clicking outside the confirmation dialog will close it without action.
…4915 Update close action to close dialog without confirmation.
Don't close site.xml modal without warning, if something is not saved #4915
Some apps have a lot of settings for their site.xml. But if you edit these and by accident click outside the modal (on the black overlay background), the modal is closed without warning and all your changes are lost.
Prompt me with a warning before closing the modal! Also make sure the same happens when clicking any other close or cancel button. The user needs an extra chance to stop changes from being lost. The same way closing the edit of any other content works.
Click on the dark area and all changes are lost and the modal is closed. Not optimal UX.
The text was updated successfully, but these errors were encountered: