Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Configurator Dialog - Image in a htmlArea overlaps buttons on the toolbar #5028

Closed
sgauruseu opened this issue May 30, 2017 · 1 comment
Closed

Site Configurator Dialog - Image in a htmlArea overlaps buttons on the toolbar #5028

sgauruseu opened this issue May 30, 2017 · 1 comment
Assignees
@edloidas
Labels
Bug

Comments

@sgauruseu
Copy link
Member

The issue does not reproduce in htmlArea content, only in SiteConfigurator modal dialog

  1. Open a site, open the site configurator(it should be with the htmlArea)
  2. insert an image in the area, click on the Insert button.
    3.press the Apply
  3. open the dialog again
    BUGS
  4. the image overlaps the toolbar on the dialog
  5. try to delete the image(Press Delete button on the keyboard) and click on the Apply button,
    the dialog does not close when the button has been clicked

site-conf
@sgauruseu sgauruseu added the Bug label May 30, 2017
@alansemenov
Copy link
Member

@edloidas Can you look at this please? Probably caused by #4914

edloidas added a commit that referenced this issue May 30, 2017
@edloidas
Site Configurator Dialog - Image in a htmlArea overlaps buttons on th…
8a6e239 
…e toolbar #5028

`HtmlArea` is auto resizing on inner html changed. Sometimes it led to `SiteConfiguratorDialog` size change, that wasn't tracked.
Added HtmlArea size change listeners to `SiteConfiguratorDialog`
@edloidas edloidas mentioned this issue May 30, 2017
Merged
@srs srs closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edloidas edloidas

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srs @edloidas @sgauruseu @alansemenov