Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vacuum stops on broken blob #9601

Closed
rymsha opened this issue Aug 1, 2022 · 1 comment
Closed

Vacuum stops on broken blob #9601

rymsha opened this issue Aug 1, 2022 · 1 comment
Assignees
@rymsha
Labels
Bug
Milestone
7.11.0

Comments

@rymsha
Copy link
Contributor

rymsha commented Aug 1, 2022 •
edited
Loading

When Vacuum hits a broken node it aborts the entire process.
Instead it could log a warning and assume the node might be in use - don't delete it.
@rymsha rymsha added the Bug label Aug 1, 2022
@rymsha rymsha mentioned this issue Aug 1, 2022
Open
@rymsha rymsha assigned rymsha and unassigned vbradnitski Aug 22, 2022
rymsha added a commit that referenced this issue Aug 22, 2022
@rymsha
Vacuum stops on broken blob #9601
12b4232
rymsha added a commit that referenced this issue Aug 22, 2022
@rymsha
Vacuum stops on broken blob #9601
c1d464a
@rymsha
Copy link
Contributor Author

rymsha commented Aug 22, 2022

There is no actual need to load entire node when doing vacuum. BranchService can be used instead to check version match.
In this case broken blobs won't affect vacuum and it will be a performance boost, too.

@rymsha rymsha added this to the 7.11.0 milestone Aug 22, 2022
rymsha added a commit that referenced this issue Aug 23, 2022
@rymsha
Vacuum stops on broken blob #9601
e0d1e96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymsha rymsha

Labels
Bug
Projects
None yet
Milestone
7.11.0
Development

No branches or pull requests
3 participants
@rymsha @vbradnitski @alansemenov