StatusServlet fails to render an error #10067 #10068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #10068 +/- ##
=========================================
Coverage 84.07% 84.08%
Complexity 19292 19292
=========================================
Files 2585 2585
Lines 67726 67724 -2
Branches 5424 5424
=========================================
Hits 56943 56943
+ Misses 8126 8124 -2
Partials 2657 2657
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rymsha
reviewed
Mar 6, 2023
| out.println( json.toString() ); | ||
| out.close(); | ||
| final OutputStream out = res.getOutputStream(); | ||
| out.write( json.toString().getBytes( StandardCharsets.UTF_8 ) ); |
There was a problem hiding this comment.
It is possible to save one copy if you open a response Writer and write a resulting string directly.
Note that Jetty uses encoding ContentType - so we will be fine.
To get really mad about performance we can use JsonWriter but it would complicate the code
rymsha
approved these changes
Mar 6, 2023
anatol-sialitski
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.