Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management SSE for apps fails when Accept-Encoding is sent #8518 #8520

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Dec 1, 2020

Main fix: disabled gzip for SSE. At least for now. see #8518 (comment)

A few other polishes:

That causes race conditions for us, so sse Context variable is set, I ignore others

  • In case of not yet set contextHolder we should throw an error (well, it never happens, but still...), otherwise, if no error is thrown, client just hangs and never receives any messages

  • Last fix is to send "list" message before any others can potentially arrive.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #8520 (6409dfe) into master (0f1d172) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8520      +/-   ##
============================================
- Coverage     82.08%   82.08%   -0.01%     
  Complexity    19588    19588              
============================================
  Files          2769     2769              
  Lines         70464    70467       +3     
  Branches       5792     5793       +1     
============================================
+ Hits          57842    57844       +2     
- Misses         9457     9458       +1     
  Partials       3165     3165              
Impacted Files Coverage Δ Complexity Δ
.../com/enonic/xp/impl/server/rest/SseEntryPoint.java 93.22% <80.00%> (-1.52%) 14.00 <1.00> (ø)
.../web/jetty/impl/configurator/GZipConfigurator.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ic/xp/core/impl/content/ParentProjectSyncTask.java 91.83% <0.00%> (ø) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1d172...6409dfe. Read the comment docs.

@rymsha
Copy link
Contributor Author

rymsha commented Dec 1, 2020

issue about double injection submitted https://issues.redhat.com/browse/RESTEASY-2779

@rymsha rymsha merged commit 4cfbbd0 into master Dec 2, 2020
@rymsha rymsha deleted the issue-8518 branch December 2, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants