Fix regression #113
Merged
Fix regression #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed here: 9aa339d |
|
trying to recall why, but it's been so long since I used the code that I don't remember :P |
|
So, @tagliala @enriclluelles is it good enough to be merged? |
|
Merged like there ain't no tomorrow, thanks! |
|
@tagliala maybe it's time for new version? Patch at least? |
|
I think I don't have the permission to push on rubygems |
|
Hey @tagliala, I'll add you later today! |
| @@ -24,4 +24,11 @@ def set_locale_from_url | |||
| I18n.locale = current_locale if tmp_locale | |||
| end | |||
| end | |||
|
|
|||
| class TestCase | |||
There was a problem hiding this comment.
|
@kirillplatonov could you please give a try to gem 'route_translator', github: 'enriclluelles/route_translator', branch: 'feature/remove-test-case'All tests are still passing, the coverage does not include that code and specs of other applications of mine based on route_translator still pass. |
|
I'm going to release a new version without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #45 fixed issues #27 and #71. But related code was removed from
master at some point. Bring it back.