Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Layout breaks on macOS with Amethyst #255

Closed
peperunas opened this issue Dec 3, 2023 · 4 comments
Closed

[BUG] Layout breaks on macOS with Amethyst #255

peperunas opened this issue Dec 3, 2023 · 4 comments
Milestone

Comments

@peperunas
Copy link

Describe the bug
The page layout breaks when the windows are moved around with Amethyst on macOS. My setup is with two monitors, one of which is an ultrawide.

When switching modes (column, row, and so on), the content are is not rendered correctly, and the boundaries go out-of-screen. There is no way to revert - to the best of my knowledge - but to clean up the session and start from scratch.

Where is it happening?

  • Which device [Mobile/Desktop, os version]: Desktop, macOS, Firefox
  • Which browser:
  • Which website: Self-hosted, latest Git version

Screenshots / context

image

@enricoros
Copy link
Owner

enricoros commented Dec 4, 2023

Thanks for posting, a couple of questions, that's the layout is mostly dictated by the browser.

  • which browser is running on, and did you install the web page as app?
  • have you tried switching to preferences > page size > full?
  • does a horizontal scrollbar appear (on hover) in the screenshot above?
  • (if you could post the full screen window of the app, I'd better understand the layout)

Very timely as I'm about to redo the main layout (but the message layout is what gives you the issue).

@enricoros
Copy link
Owner

enricoros commented Dec 18, 2023

Closing due to lack of reproducibility.

enricoros added a commit that referenced this issue Dec 27, 2023
Also Fix #255 due to the large layout restructuring.
@enricoros
Copy link
Owner

This should fix it. Verified with Firefox.
8bf90e3

Will land when the feature-newi branch gets merged, in a couple of days.

@enricoros enricoros added this to the 1.9.0 milestone Dec 28, 2023
enricoros added a commit that referenced this issue Dec 28, 2023
 - Optima Layout: new Context based pluggable layout system
   - Now children have context functions, for better behaviors
   - Removed `store-applayout`
   - using withLayout on top-level Pages
 - ScrollToBottom: grounds-up subsystem for smooth scrolling with snap-to-bottom
 - Panes subsystem: use react-resizeable-panels together with our Panes subsystem
   - New: Split window chats, Drag to close windows, Button to split
   - using: https://github.com/bvaughn/react-resizable-panels
 - Cosmetic: Colors: update Light and Dark themes
 - Bootstrap Logic provider: will enable Mobile use cases
 - Removed NoSSR (the backend provided natually acts as the same)
 - Next load progress: loading indicator for slower pages (>300ms)
 - withLayout() system

Additional benefits include: no-pluggable-flashing, pane-ready,
fixed X-scrolling on Firefox, and more.

Closes #308, #304, #255, #59.
Progress on #305, #201, #296, #233, #208, #203.
@enricoros
Copy link
Owner

Fixed on the main branch; queued up for the next stable release (1.0.9)

@enricoros enricoros mentioned this issue Dec 28, 2023
22 tasks
LennardSchwarz added a commit to LennardSchwarz/lenns-big-agi that referenced this issue Dec 30, 2023
* [Visualize] Add custom instruction enricoros#218

* Better 1-click deployment, fixes enricoros#279

* Fix.

* DB: drop URL validation for POSTGRES_PRISMA_URL. enricoros#277

* Fix shortcuts on Mac.

* Anthropic: allow for 39 chars sks

* Move ModelVendor enum

* LLMOptions Modal: fix display

* Gemini: backend env var

* LLM Vendors: auto IDs

* Gemini: configuration, list models, and immediate generation

* Bits for the future

* Streaming: cleanup

* Gemini: cleaner

* Llms: cleanup model lists

* Llms: cleanup model lists (bits)

* Llms: restructure

* Llms: move models modal

* Llms: improve list generics

* Llms: vendor-specific RPC to ChatGenerate

* Llms: streaming as a vendor function (then all directed to the unified)

* Models List: show a helpful message

* Models Modal: improve caps

* Gemini: client version

* Gemini: trim key

* Gemini: stream on

* Gemini: final touches

* Streaming: muxing format

* Gemini: show block reason

* Gemini: choose a content filtering threshold

* OpenRouter: update models

* OpenRouter: update models

* Ollama: update admin panel

* Ollama: update models

* 1.8.0: Version

* 1.8.0: news.data.tsx

* 1.8.0: Readme and Changelog

* Maintainers Release

* Added Persona from Text

* Optimzed text to cover both use cases

* Persona Creator: style: update TextArea and margins

* Persona Creator: remove YT -> renamed to PersonaCreator.tsx

* Persona Creator: reorder blocks, and show the LLM name

* Persona Creator: rename model selector label

* Persona Creator: change the 'copy' location and improve paddings

* Persona Creator: final fix I swear

* Persona Creator: remove the 'Labs' flag

* Persona Creator: consistent naming

* Persona Creator: on by default, can be hidden like other tiles

* fix to reset state when switching between modes.

* Imagine: remove former 'mode'

* Imagine: unified pipeline. Adds to enricoros#289

* OpenRouter: drop the hardcoded list

* LLMOptions: improve display (add tooltips and advanced)

* Models Loading progress

* LLM Options: display Free models

* DLLM: add a 'Free' attribute (only on OpenRouter for now)

Shall have this on Local models as well?

* Implement Rate limiting framework

* OpenRouter: limit free model calls to 1/5s. Closes enricoros#291

* Metadata: update

* Roll packages

* Llms: Cleanup some type definitions

* OpenAI: router: generate images

* T2I: move Prodia in the Text2Image module

* T2I: cmd change

* T2I: openAI generation

* T2I: capabilities update

* T2I: client (capabilities, immediate generation)

* bits

* T2I: integrate with OpenAI Access credentials

* T2I: capability checks

* misc: rename file

* T2I: move methods around

* T2I: misc

* T2I: improvements

* FormRadioControl: improve mobile, support undefined

* Image Block: add Dalle

* T2I: fix OpenAI DallE path

* T2I: Settings (choose active)

* T2I: remove auto-set from OpenAI setup

* T2I: move store

* RenderImage: vastly improve the Image Block, incl. the ALT Text

* Parse the new markdown image blocks

* Dalle: improve typedefs

* Dalle: improve configuration

* TTI: return Markdown Image References.

Will be rendered neatly with or without markdown on.

* T2I: tti -> t2i

* T2I: Final Naming and Cleanups. Closes enricoros#212

* Bits

* RenderImage: larger tooltip

* Dall-E: show pricing when changing settings

* Settings: light outline

* Pixels

* DallE3: support multiple parallel image request for count>1

* Theme: update background shades for Light and Dark

* More uniform App backgrounds

* Remove NoSSR: the Backend provider does the same and doesn't seem to flash the screen that much

* Optimize

* Dynamic layouting

* Fix

* Deflate bundle by reverting to per-page Layouts (keep the typings at least)

* Next Router Loading Progress

* GoodDropdown shared

* Move providers

* Move this (unused) utility

* Providers into a dedicated folder

* Add the Bootstrap Logic provider

* BootstrapProvider: check for mobile

* Improve routing

* Routing bits

* Routing shall be homogeneous now

* OptimaLayout: migrate to Context for better React usage

* AppBar: begin cleanup

* Disable debug

* OptimaLayout: begin

* Composer: fix attachments layout

* Use `react-resizable-panels` instead of the flexbox

Also Fix enricoros#255 due to the large layout restructuring.

* Panes: duplicate current

* Panes: move

* Scroller: straighten messages

* Scroller: straighten messages (remove bottoms)

* Scroller: framework (incomplete), Fixes enricoros#59

* Scroller: vastly improve the framework

* Scroller: begins to work well

* Update year, almost there

* Scroll-To-Bottom: complete Framework. Fixes enricoros#304, Fixes enricoros#60, Fixes enricoros#59

* Release: update template

* Release: update template

* Release: update template

* DALL·E: temporary image notice

* 1.9.0: Version

* DALL·E: raw prompting for DALL·E 3 as well

* DALL·E: reorder options

* 1.9.0: News

* Release: update template

* 1.9.0: README and Changelog

---------

Co-authored-by: Joris Kalz <joris@kalz.de>
Co-authored-by: Enrico Ros <enrico.ros@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
LennardSchwarz pushed a commit to LennardSchwarz/lenns-big-agi that referenced this issue Jan 1, 2024
Also Fix enricoros#255 due to the large layout restructuring.
LennardSchwarz added a commit to LennardSchwarz/lenns-big-agi that referenced this issue Jan 1, 2024
* [Visualize] Add custom instruction enricoros#218

* Better 1-click deployment, fixes enricoros#279

* Fix.

* DB: drop URL validation for POSTGRES_PRISMA_URL. enricoros#277

* Fix shortcuts on Mac.

* Anthropic: allow for 39 chars sks

* Move ModelVendor enum

* LLMOptions Modal: fix display

* Gemini: backend env var

* LLM Vendors: auto IDs

* Gemini: configuration, list models, and immediate generation

* Bits for the future

* Streaming: cleanup

* Gemini: cleaner

* Llms: cleanup model lists

* Llms: cleanup model lists (bits)

* Llms: restructure

* Llms: move models modal

* Llms: improve list generics

* Llms: vendor-specific RPC to ChatGenerate

* Llms: streaming as a vendor function (then all directed to the unified)

* Models List: show a helpful message

* Models Modal: improve caps

* Gemini: client version

* Gemini: trim key

* Gemini: stream on

* Gemini: final touches

* Streaming: muxing format

* Gemini: show block reason

* Gemini: choose a content filtering threshold

* OpenRouter: update models

* OpenRouter: update models

* Ollama: update admin panel

* Ollama: update models

* 1.8.0: Version

* 1.8.0: news.data.tsx

* 1.8.0: Readme and Changelog

* Maintainers Release

* Added Persona from Text

* Optimzed text to cover both use cases

* Persona Creator: style: update TextArea and margins

* Persona Creator: remove YT -> renamed to PersonaCreator.tsx

* Persona Creator: reorder blocks, and show the LLM name

* Persona Creator: rename model selector label

* Persona Creator: change the 'copy' location and improve paddings

* Persona Creator: final fix I swear

* Persona Creator: remove the 'Labs' flag

* Persona Creator: consistent naming

* Persona Creator: on by default, can be hidden like other tiles

* fix to reset state when switching between modes.

* Imagine: remove former 'mode'

* Imagine: unified pipeline. Adds to enricoros#289

* OpenRouter: drop the hardcoded list

* LLMOptions: improve display (add tooltips and advanced)

* Models Loading progress

* LLM Options: display Free models

* DLLM: add a 'Free' attribute (only on OpenRouter for now)

Shall have this on Local models as well?

* Implement Rate limiting framework

* OpenRouter: limit free model calls to 1/5s. Closes enricoros#291

* Metadata: update

* Roll packages

* Llms: Cleanup some type definitions

* OpenAI: router: generate images

* T2I: move Prodia in the Text2Image module

* T2I: cmd change

* T2I: openAI generation

* T2I: capabilities update

* T2I: client (capabilities, immediate generation)

* bits

* T2I: integrate with OpenAI Access credentials

* T2I: capability checks

* misc: rename file

* T2I: move methods around

* T2I: misc

* T2I: improvements

* FormRadioControl: improve mobile, support undefined

* Image Block: add Dalle

* T2I: fix OpenAI DallE path

* T2I: Settings (choose active)

* T2I: remove auto-set from OpenAI setup

* T2I: move store

* RenderImage: vastly improve the Image Block, incl. the ALT Text

* Parse the new markdown image blocks

* Dalle: improve typedefs

* Dalle: improve configuration

* TTI: return Markdown Image References.

Will be rendered neatly with or without markdown on.

* T2I: tti -> t2i

* T2I: Final Naming and Cleanups. Closes enricoros#212

* Bits

* RenderImage: larger tooltip

* Dall-E: show pricing when changing settings

* Settings: light outline

* Pixels

* DallE3: support multiple parallel image request for count>1

* Theme: update background shades for Light and Dark

* More uniform App backgrounds

* Remove NoSSR: the Backend provider does the same and doesn't seem to flash the screen that much

* Optimize

* Dynamic layouting

* Fix

* Deflate bundle by reverting to per-page Layouts (keep the typings at least)

* Next Router Loading Progress

* GoodDropdown shared

* Move providers

* Move this (unused) utility

* Providers into a dedicated folder

* Add the Bootstrap Logic provider

* BootstrapProvider: check for mobile

* Improve routing

* Routing bits

* Routing shall be homogeneous now

* OptimaLayout: migrate to Context for better React usage

* AppBar: begin cleanup

* Disable debug

* OptimaLayout: begin

* Composer: fix attachments layout

* Use `react-resizable-panels` instead of the flexbox

Also Fix enricoros#255 due to the large layout restructuring.

* Panes: duplicate current

* Panes: move

* Scroller: straighten messages

* Scroller: straighten messages (remove bottoms)

* Scroller: framework (incomplete), Fixes enricoros#59

* Scroller: vastly improve the framework

* Scroller: begins to work well

* Update year, almost there

* Scroll-To-Bottom: complete Framework. Fixes enricoros#304, Fixes enricoros#60, Fixes enricoros#59

* Release: update template

* Release: update template

* Release: update template

* DALL·E: temporary image notice

* 1.9.0: Version

* DALL·E: raw prompting for DALL·E 3 as well

* DALL·E: reorder options

* 1.9.0: News

* Release: update template

* 1.9.0: README and Changelog

---------

Co-authored-by: Joris Kalz <joris@kalz.de>
Co-authored-by: Enrico Ros <enrico.ros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants