Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Layout breaks on macOS with Amethyst #255

Closed
peperunas opened this issue Dec 3, 2023 · 4 comments
Closed

[BUG] Layout breaks on macOS with Amethyst #255

peperunas opened this issue Dec 3, 2023 · 4 comments
Milestone
1.9.0

Comments

@peperunas
Copy link

Describe the bug
The page layout breaks when the windows are moved around with Amethyst on macOS. My setup is with two monitors, one of which is an ultrawide.

When switching modes (column, row, and so on), the content are is not rendered correctly, and the boundaries go out-of-screen. There is no way to revert - to the best of my knowledge - but to clean up the session and start from scratch.

Where is it happening?

  • Which device [Mobile/Desktop, os version]: Desktop, macOS, Firefox
  • Which browser:
  • Which website: Self-hosted, latest Git version

Screenshots / context

image
@enricoros
Copy link
Owner

enricoros commented Dec 4, 2023 •
edited
Loading

Thanks for posting, a couple of questions, that's the layout is mostly dictated by the browser.

  • which browser is running on, and did you install the web page as app?
  • have you tried switching to preferences > page size > full?
  • does a horizontal scrollbar appear (on hover) in the screenshot above?
  • (if you could post the full screen window of the app, I'd better understand the layout)

Very timely as I'm about to redo the main layout (but the message layout is what gives you the issue).

@enricoros
Copy link
Owner

enricoros commented Dec 18, 2023 •
edited
Loading

Closing due to lack of reproducibility.

enricoros added a commit that referenced this issue Dec 27, 2023
@enricoros
Use react-resizable-panels instead of the flexbox
8bf90e3 
Also Fix #255 due to the large layout restructuring.
@enricoros
Copy link
Owner

This should fix it. Verified with Firefox.
8bf90e3

Will land when the feature-newi branch gets merged, in a couple of days.

@enricoros enricoros added this to the 1.9.0 milestone Dec 28, 2023
enricoros added a commit that referenced this issue Dec 28, 2023
@enricoros
New UI - Part 1 - Details inside:
d775d47 
 - Optima Layout: new Context based pluggable layout system
   - Now children have context functions, for better behaviors
   - Removed `store-applayout`
   - using withLayout on top-level Pages
 - ScrollToBottom: grounds-up subsystem for smooth scrolling with snap-to-bottom
 - Panes subsystem: use react-resizeable-panels together with our Panes subsystem
   - New: Split window chats, Drag to close windows, Button to split
   - using: https://github.com/bvaughn/react-resizable-panels
 - Cosmetic: Colors: update Light and Dark themes
 - Bootstrap Logic provider: will enable Mobile use cases
 - Removed NoSSR (the backend provided natually acts as the same)
 - Next load progress: loading indicator for slower pages (>300ms)
 - withLayout() system

Additional benefits include: no-pluggable-flashing, pane-ready,
fixed X-scrolling on Firefox, and more.

Closes #308, #304, #255, #59.
Progress on #305, #201, #296, #233, #208, #203.
@enricoros
Copy link
Owner

Fixed on the main branch; queued up for the next stable release (1.0.9)

@enricoros enricoros mentioned this issue Dec 28, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@enricoros @peperunas