Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strk support #365

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Strk support #365

merged 6 commits into from
Dec 5, 2022

Conversation

makoto
Copy link
Member

@makoto makoto commented Nov 29, 2022

Issue number

#363

Description

Support Starknet coin types

Reference to the specification

Reference to the test address.

https://github.com/0xs34n/starknet.js/blob/develop/__tests__/utils/address.test.ts#L29

List of features added/changed

  • Port starknet js (to reduce file size)
  • Add support for STRK cointype

NOTE: If you are adding new coin address support, please make sure to add a reference link to README so that reviewer can verify.

How much has the filesize increased?

411004 -> 418890 (1459248 if the entirestarknet lib is imported)

How Has This Been Tested?

https://strk.ens-app.pages.dev/name/matoken.eth/details (on Goerli)

Screenshot 2022-11-29 at 16 20 37

Checklist:

  • My code follows the code style of this project.
  • My code implements all the required features.
  • I have specified correct coinTypes specified at Slip 44
  • I have provided the reference link to the specification I implemented.
  • I have provided enough explanation about how I provided the test address

@makoto makoto requested a review from Arachnid November 29, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant