Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the @ethvault/iframe-provider-polyfill to support iframe wallets #405

Closed
wants to merge 1 commit into from
Closed

Conversation

moodysalem
Copy link

See #388 for context

@moodysalem
Copy link
Author

It looks like the package @ensdomains/ui contains the web3 setup code. It doesn't look like a user choice AFAICT. I can add the following to that package in setupWeb3, if preferable:

  • check if window is in iframe
    • try to enable the iframe provider via await iframeProvider.enable()
      • if enable succeeds, set window.ethereum and window.web3 to iframeProvider
      • if enable fails or takes longer than 1 second, do nothing
  • if not in iframe, do nothing

Since it's shared code, it would enable the provider in all the ENS apps that use it.

@moodysalem
Copy link
Author

I will pursue an audit via EthereumCommonwealth/Auditing#351

@moodysalem
Copy link
Author

Here is that alternative implementation
ensdomains/ui#18

@makoto
Copy link
Member

makoto commented Aug 14, 2019

Duplicate to #421

@makoto makoto closed this Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants