Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default reverse resolver #335

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
3543c17
Update REVERSE_NAMESPACE
makoto Jan 22, 2024
13a8664
Redeploy all contracts with official reverse namespace (cointype.reve…
makoto Jan 23, 2024
8bac204
Add DefaultReverseResolver
makoto Feb 12, 2024
8d8f7e5
Move sha3HexAddress to LowLevelCallUtils
makoto Feb 12, 2024
9a2e281
L2ReverseRegistrar to inherit SinatureReverseResolver.sol
makoto Feb 14, 2024
94de1e2
Move node function to SignatureReverseResolver
makoto Feb 14, 2024
8b966e9
Add test for resolve
makoto Feb 14, 2024
d73b7d1
Remove unused code
makoto Feb 14, 2024
357edb5
Refactor the test to use makeSignature
makoto Feb 15, 2024
0297ddd
Add hardhat-storage-layout
makoto Feb 15, 2024
01d8af8
Remove hardhat-storage-layout
makoto Feb 19, 2024
e44c7b8
Remove hardhat-verify
makoto Feb 19, 2024
a6fa28e
Remove .resolve
makoto Feb 21, 2024
3dda800
emit NameChanged and TextChanged
makoto Feb 22, 2024
b88c538
Add comments on functions
makoto Feb 22, 2024
3636c8b
Update comment
makoto Feb 22, 2024
29dced0
Remove DefaultReverseResolver
makoto Feb 22, 2024
5ea0cc9
Redeployed L2ReverseRegistrar
makoto Feb 22, 2024
b1ed3ef
Add revert
makoto Feb 23, 2024
8eaa28e
Remove DefaultReverseResolver.sol
makoto Feb 26, 2024
9659671
Change from ParentNode to parentNode
makoto Mar 1, 2024
b58226f
Remove node function from interface
makoto Mar 1, 2024
ad32e16
Update contracts/reverseRegistrar/SignatureReverseResolver.sol
makoto Mar 1, 2024
0d9c80c
Remove getLastUpdated
makoto Mar 1, 2024
00c62bf
Merge branch 'default-reverse-resolver' of https://github.com/ensdoma…
makoto Mar 1, 2024
46c6e22
Remove duplicate NameChanged
makoto Mar 1, 2024
622b64c
Move name and text to SignatureReverseResolver.sol
makoto Mar 4, 2024
3e8036c
Reuse sha3HexAddress
makoto Mar 4, 2024
5706812
Change from coinType to chainId
makoto Mar 7, 2024
e04ea15
Use EIP-191 for message signing
makoto Mar 28, 2024
6656b65
Pass chainId instead of coinType
makoto Mar 28, 2024
f1f5024
Change from chainId.reverse to coinType.reverse
makoto Mar 28, 2024
18d4b17
Use using LowLevelCallUtils for address;
makoto Mar 28, 2024
469086e
Revert back from chainId to coinType
makoto Mar 28, 2024
607fa18
Externalize the message computation
makoto Mar 28, 2024
7505c12
Remove Ownable
makoto Mar 28, 2024
56005b8
Update contracts/reverseRegistrar/SignatureReverseResolver.sol
makoto Apr 4, 2024
68d59c7
Remove unnecessary comments and function body
makoto Apr 4, 2024
3b69cd7
Merge branch 'default-reverse-resolver' of https://github.com/ensdoma…
makoto Apr 4, 2024
305e12f
Rename computeMessage with getSignedMessageHash
makoto Apr 4, 2024
9c4e595
Remove '0x19' and '0x00' and rename SignatureOutOfDate to InvalidSig…
makoto Apr 5, 2024
bda9d5e
Rename from IL2ReverseRegistrar to IL2ReverseResolver
makoto Apr 6, 2024
fd1df91
Rename L2ReverseRegistrar to L2ReverseResolver
makoto Apr 6, 2024
350c0d1
Rename the file
makoto Apr 6, 2024
d7a6a4a
Rename from L2ReverseRegistrar.sol to L2ReverseResolver.sol
makoto Apr 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
pragma solidity >=0.8.4;

interface IL2ReverseRegistrar {
interface IL2ReverseResolver {
function setName(string memory name) external returns (bytes32);

function setNameForAddr(
address addr,
string memory name
) external returns (bytes32);

function setNameForAddrWithSignature(
address addr,
string memory name,
uint256 inceptionDate,
bytes memory signature
) external returns (bytes32);

function setNameForAddrWithSignatureAndOwnable(
address contractAddr,
address owner,
Expand All @@ -34,14 +27,6 @@ interface IL2ReverseRegistrar {
string calldata value
) external returns (bytes32);

function setTextForAddrWithSignature(
address addr,
string calldata key,
string calldata value,
uint256 inceptionDate,
bytes memory signature
) external returns (bytes32);

function setTextForAddrWithSignatureAndOwnable(
address contractAddr,
address owner,
Expand All @@ -52,12 +37,4 @@ interface IL2ReverseRegistrar {
) external returns (bytes32);

function clearRecords(address addr) external;

function clearRecordsWithSignature(
address addr,
uint256 inceptionDate,
bytes memory signature
) external;

function node(address addr) external view returns (bytes32);
}
41 changes: 41 additions & 0 deletions contracts/reverseRegistrar/ISignatureReverseResolver.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
pragma solidity >=0.8.4;

interface ISignatureReverseResolver {
event VersionChanged(bytes32 indexed node, uint64 newVersion);
event ReverseClaimed(address indexed addr, bytes32 indexed node);
Arachnid marked this conversation as resolved.
Show resolved Hide resolved
event NameChanged(bytes32 indexed node, string name);
Arachnid marked this conversation as resolved.
Show resolved Hide resolved
event TextChanged(
bytes32 indexed node,
string indexed indexedKey,
string key,
string value
);

function setNameForAddrWithSignature(
address addr,
string memory name,
uint256 inceptionDate,
bytes memory signature
) external returns (bytes32);

function setTextForAddrWithSignature(
address addr,
string calldata key,
string calldata value,
uint256 inceptionDate,
bytes memory signature
) external returns (bytes32);

function clearRecordsWithSignature(
address addr,
uint256 inceptionDate,
bytes memory signature
) external;

function name(bytes32 node) external view returns (string memory);

function text(
bytes32 node,
string calldata key
) external view returns (string memory);
}
Loading
Loading