Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Redo #483

Closed
3 tasks
iamrecursion opened this issue Feb 21, 2020 · 0 comments
Closed
3 tasks

Implement Redo #483

iamrecursion opened this issue Feb 21, 2020 · 0 comments
Assignees
@lolczak
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints

Comments

@iamrecursion
Copy link
Contributor

iamrecursion commented Feb 21, 2020 •
edited by joenash
Loading

Summary

With the design for redo specified as part of #485, we now need to implement the underlying functionality.

Value

Clients will be able to redo edits.

Specification

  • Implement the text/redo message as specified in the same [design document(https://github.com/enso-org/enso/blob/master/doc/design/engine/engine-services.md)
  • This should use the functionality for tracking user action stacks implemented as part of Implement Undo #484.
  • Document any errors that are added as part of this proposal in the design document.

Acceptance Criteria & Test Cases

  • The redo functionality has been implemented.
  • The redo functionality has been rigorously tested.
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added -tooling Category: tooling Change: Non-Breaking p-medium Should be completed in the next few sprints labels Jun 23, 2020
@iamrecursion iamrecursion mentioned this issue Jun 24, 2020
Closed
3 tasks
@wdanilo wdanilo closed this as completed Apr 14, 2022
somebody1234 added a commit that referenced this issue Jun 1, 2023
@somebody1234
Remove modal from file upload flow
f001d50 
Fixes part of cloud-v2/#483
somebody1234 added a commit that referenced this issue Jun 1, 2023
@somebody1234
Add optimistic UI; add more toast messages
5e25c6e 
Fixes part of cloud-v2/#483
PabloBuchu pushed a commit that referenced this issue Jun 28, 2023
@somebody1234
(even more) Dashboard fixes (#6919)
b4d0a40 
* Change cdn domain

Fixes cloud-v2/#484

* Remove modal from file upload flow

Fixes part of cloud-v2/#483

* Add optimistic UI; add more toast messages

Fixes part of cloud-v2/#483

* Handle `authentication` and `new-dashboard` flags correctly

Fixes cloud-v2/#481

* Fix bugs

* Use offline mode when `-authentication=false`

* Stop row from resizing when loading permissions

* Fix issues

* Navigate back to login screen on registration success

* Prevent scrollbar flickering

The scrollbar still blinks when switching backends, but it now does not resize. The blinking seems to be very difficult to avoid.

* Stop modal close button from overlapping text

* Fix stop icon spinning when switching backends

Remote backend not tested

* Remove modal from files table plus button

* Scrollbar-aware column count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolczak lolczak

Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wdanilo @joenash @iamrecursion @lolczak