Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text displays with extra spaces #7492

Closed
2 tasks
Tracked by #8032
GregoryTravis opened this issue Aug 3, 2023 · 9 comments
Closed
2 tasks
Tracked by #8032

Text displays with extra spaces #7492

GregoryTravis opened this issue Aug 3, 2023 · 9 comments
Assignees
Labels
--bug Type: bug -viz p-lowest Should be completed at some point s-invalid Status: not valid for some reason

Comments

@GregoryTravis
Copy link
Contributor

Discord username

No response

What type of issue is this?

Intermittent – Occurring irregularly

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

I'm testing Text.normalize (#7425), and in some cases, a normalized text string is displayed with extra spaces. Just to be sure, I checked the length and codepoints of the two strings, and they are identical. I even converted the codepoints back to strings, and those display correctly. It also seems correct when run at the command line.

Expected behaviour

Expect the text to be displayed without a gap.

How we can reproduce it?

  1. Create a text node
  2. Normalize it
  3. View the output

Screenshots or screencasts

The "operator1.normalize" node is displaying the string with a gap:

Screen Shot 2023-08-03 at 11 35 03 AM

You can see it full screen here:

Screen Shot 2023-08-03 at 11 33 01 AM

Logs

No response

Enso Version

Local build at 9e9cf0b

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

Monterey 12.6.3

Hardware you are using

MacBook Air (M1, 2020)

@kazcw
Copy link
Contributor

kazcw commented Aug 3, 2023

I encountered something similar:

After scrolling a JSON visualization and scrolling back to the beginning, the beginning became space:
image

It happened once while I was testing #7475 (though I don't think it was caused by that PR), and I have not been able to reproduce it. On Linux in my case.

@farmaazon
Copy link
Contributor

I cannot reproduce it on my end, but this may be just an instance of #7332. Let's check after fixing that if you still reproduce the issue.

@MichaelMauderer
Copy link
Contributor

@GregoryTravis Can you confirm whether this is fixed now?

@farmaazon
Copy link
Contributor

@GregoryTravis bump ^

@GregoryTravis
Copy link
Contributor Author

This is fixed!

@radeusgd
Copy link
Member

radeusgd commented Sep 4, 2023

I've found a related bug and was directed here. My issue occurs still at latest develop.

displaced-text-vis.mp4

If I drag-and-drop this text file into Enso:
text.txt

and open the visualization - a part of the text gets displaced:
image

@radeusgd
Copy link
Member

radeusgd commented Sep 4, 2023

So I did some digging out of curiosity and it seems that my payload contained a Carriage Return (\r) and this seems to mess up the visualization. If replaced by Line Feed (\n) it goes back to normal.

For comparison:
image

@farmaazon farmaazon reopened this Sep 4, 2023
@farmaazon farmaazon added the p-high Should be completed in the next sprint label Sep 4, 2023
@radeusgd
Copy link
Member

radeusgd commented Sep 4, 2023

(Note that it did not work for me on shorter inputs like 'a\rb' or 'abc\rdef'. I suspect the input may need to be long enough to trigger and trip the chunking mechanism. You can always use the sentence from the repro file.)

@jdunkerley jdunkerley added p-lowest Should be completed at some point and removed p-high Should be completed in the next sprint labels Sep 11, 2023
@farmaazon
Copy link
Contributor

We don't use lazy JSON visualization in GUI. If we do, it will be tested again against such issues. Closing for now.

@farmaazon farmaazon closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
@farmaazon farmaazon added the s-invalid Status: not valid for some reason label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -viz p-lowest Should be completed at some point s-invalid Status: not valid for some reason
Projects
Archived in project
Development

No branches or pull requests

7 participants