Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Unicode normalization methods on Texts #7425

Merged
merged 19 commits into from
Aug 3, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Jul 28, 2023

Pull Request Description

Exposes Text_Utils.normalize().

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review July 28, 2023 19:11
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 31, 2023
@jdunkerley jdunkerley linked an issue Aug 1, 2023 that may be closed by this pull request
NFKC
# Unicode standard NFKD
NFKD
# Unicode standard NFKC_CF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate some explanation what case folding here involves, although maybe it is not needed since it's an advanced feature so we can expect the user to know/google this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're not easy to summarize briefly. Following the Java documentation, I just name them clearly and assume anyone using it will know what the mean.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fair enough

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please clean the obsolete comment and verify that the comments on Normalization constructors (e.g. NFD) are displayed in Component Browser.

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one line to remove!

Normalize a string.

'aśb'.normalize == 'as\u0301b'
@normalization Normalization.default_widget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this line.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Aug 3, 2023
@mergify mergify bot merged commit 037a687 into develop Aug 3, 2023
24 of 25 checks passed
@mergify mergify bot deleted the wip/gmt/6201-normalization branch August 3, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Unicode normalization methods on Texts
3 participants