Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context switch expression is put to CB input when editing nodes #7976

Closed
2 tasks
vitvakatu opened this issue Oct 5, 2023 · 2 comments · Fixed by #9386
Closed
2 tasks

Context switch expression is put to CB input when editing nodes #7976

vitvakatu opened this issue Oct 5, 2023 · 2 comments · Fixed by #9386
Assignees
@kazcw
Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@vitvakatu
Copy link
Contributor

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

When the context switch expression is present, and you edit the node, the expression is removed.

Expected behaviour

Edits should touch only a modifiable part of the node's expression. Any execution context switch state must be preserved.

How we can reproduce it?

  1. Disable output context for the node using a button next to it
  2. Edit the node
  3. Observe context switch is no longer present.

Screenshots or screencasts

No response

Logs

No response

Enso Version

0228022

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response
@vitvakatu vitvakatu added --bug Type: bug triage labels Oct 5, 2023
@vitvakatu vitvakatu mentioned this issue Oct 5, 2023
Merged
5 tasks
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints g-graph-editor and removed triage labels Oct 9, 2023
@farmaazon
Copy link
Contributor

The issue in GUI2 is different: now we just put the context switch code to edited input.

@farmaazon farmaazon changed the title Context switch expression is not preserved when editing nodes Context switch expression is put to CB input when editing nodes Feb 23, 2024
@farmaazon farmaazon added -gui p-high Should be completed in the next sprint and removed -gui p-medium Should be completed in the next few sprints labels Feb 23, 2024
@farmaazon farmaazon added this to the Beta Release milestone Feb 23, 2024
@farmaazon
Copy link
Contributor

Refinement notes: this shoudl be trivial after #9164 but we should also add tests.

@farmaazon farmaazon mentioned this issue Feb 29, 2024
Merged
5 tasks
@kazcw kazcw self-assigned this Mar 12, 2024
@kazcw kazcw mentioned this issue Mar 12, 2024
Merged
5 tasks
@mergify mergify bot closed this as completed in #9386 Mar 17, 2024
mergify bot pushed a commit that referenced this issue Mar 17, 2024
@kazcw
Fix CB interaction with record-mode override and add tests (#9386)
47d9e73 
Fixes #7976.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Fix CB interaction with record-mode override and add tests enso-org/enso
3 participants
@kazcw @farmaazon @vitvakatu