Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warnings on components #8678

Closed
Tracked by #9007
AdRiley opened this issue Jan 4, 2024 · 6 comments · Fixed by #9108
Closed
Tracked by #9007

Display warnings on components #8678

AdRiley opened this issue Jan 4, 2024 · 6 comments · Fixed by #9108
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 4, 2024

  • If a component has warnings display the first warning in a similar way to errors but with orange background and a warning icon.
  • Only show when node is selected and when hovering over it.
  • Ideally with a link to open the full warning list.
@AdRiley AdRiley added the -gui label Jan 4, 2024
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request labels Jan 4, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@farmaazon
Copy link
Contributor

the third point should be done in a separate task.

@somebody1234
Copy link
Collaborator

if the warning should only be shown when hovering over it, then we'd need a warning indicator, right? would that be just the orange border like in GUI1?

@enso-bot
Copy link

enso-bot bot commented Feb 16, 2024

Michael Mauderer reports a new STANDUP for yesterday (2024-02-15):

Progress: Started work on implementing the visuals for the warnings on nodes. It should be finished by 2024-02-20.

Next Day: Next day I will be working on the #8678 task. Continue with next task.

@enso-bot
Copy link

enso-bot bot commented Feb 19, 2024

Michael Mauderer reports a new STANDUP for the provided date (2024-02-16):

Progress: Continued work on visuals and integration of warnigns on nodes. It should be finished by 2024-02-20.

Next Day: Next day I will be working on the #8678 task. Continue on task.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Michael Mauderer reports a new STANDUP for yesterday (2024-02-19):

Progress: Finished work on implementation of the warnigns on nodes. It should be finished by 2024-02-20.

Next Day: Next day I will be working on the #8678 task. Cleanup code, open PR and start next task.

@AdRiley
Copy link
Member Author

AdRiley commented Feb 21, 2024

@somebody1234 Yes good call out. We should have the orange border like in GUI1.

@MichaelMauderer @farmaazon Can we do that as part of this story?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants