Display warnings on components #9108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
CI: No changelog needed
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/Display-warnings-on-components
branch
from
b54c89f
to
22908a2
Compare
MichaelMauderer
requested review from
Frizi,
farmaazon,
vitvakatu and
kazcw
as code owners
kazcw
approved these changes
Feb 20, 2024
| <GraphNodeError v-if="error" class="error" :error="error" /> | ||
| <GraphNodeError v-if="error" class="message" :message="error" type="error" /> | ||
| <GraphNodeError | ||
| v-if="warning && nodeHovered && isSelected" |
There was a problem hiding this comment.
I'm surprised by nodeHovered && isSelected here, are our conditions for showing warnings that restrictive?
There was a problem hiding this comment.
That is what was requested by @AdRiley
Only show when node is selected and when hovering over it.
Or was that meant to mean, we show it when selected OR when hovering it?
There was a problem hiding this comment.
Yes it should be OR. I should have written that better sorry.
| if (!externalId) return | ||
| const info = projectStore.computedValueRegistry.db.get(externalId) | ||
| const warning = info?.payload.type === 'Value' ? info.payload.warnings?.value : undefined | ||
| if (!warning) return undefined |
There was a problem hiding this comment.
I think return or returned undefined are both fine but let's not mix styles within one function
Co-authored-by: Kaz Wesley <kaz@lambdaverse.org>
MichaelMauderer
added
the
CI: Ready to merge
mergify
bot
deleted the
wip/MichaelMauderer/Display-warnings-on-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #8678
Peek.2024-02-20.12-45.webm
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.