Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Enso Secrets can work within the Enso Folder Structure #8723

Closed
5 tasks done
jdunkerley opened this issue Jan 10, 2024 · 1 comment · Fixed by #8791
Closed
5 tasks done

Ensure Enso Secrets can work within the Enso Folder Structure #8723

jdunkerley opened this issue Jan 10, 2024 · 1 comment · Fixed by #8791
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work x-new-feature Type: new feature request

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jan 10, 2024 •
edited by radeusgd
Loading

Want to be able to get and create secrets within a folder in the cloud.

Should be able to list secrets within a folder.

  • Create a secret in a folder.
  • Read a secret from a folder by folder_id and name.
  • List secrets in a folder.
  • Delete a secret in a folder.
  • Update value of a secret in a folder.

This assumes the Enso_File API is working we will test that in a follow up ticket.
This can only be tested against the real cloud.
@jdunkerley jdunkerley added x-new-feature Type: new feature request l-cloud-integration Enso Cloud integration work labels Jan 10, 2024
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Jan 10, 2024
This was referenced Jan 16, 2024
Closed
Closed
@radeusgd radeusgd mentioned this issue Jan 17, 2024
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 18, 2024

Radosław Waśko reports a new STANDUP for yesterday (2024-01-17):

Progress: Adding tests for secrets in subdirectories, noting missing features, implemented workaround for Enso_Secret.list. It should be finished by 2024-01-19.

Next Day: Next day I will be working on the #8590 task. Add missing Enso_Secret.update and prepare the PR. Work on types: fix a bug, cleanup.

@mergify mergify bot closed this as completed in #8791 Jan 24, 2024
mergify bot pushed a commit that referenced this issue Jan 24, 2024
@radeusgd
Tests and improvements for secrets in cloud subdirectories (#8791)
edfcfde 
- Closes #8723
- Adds some missing features that were needed to make this work:
- `Enso_File.create_directory` and `Enso_File.delete`, and basic tests for it
- Changes how `Enso_Secret.list` is obtained - using a different Cloud endpoint allows us to implement the desired logic, the default endpoint was giving us _all_ secrets which was not what we wanted here.
- Implements `Enso_Secret.update` and tests for it

# Important Notes
Notes describing any problems with the current Cloud API:
https://docs.google.com/document/d/1x8RUt3KkwyhlxGux7XUGfOdtFSAZV3fI9lSSqQ3XsXk/edit

Apparently, everything that was needed to make this feature work has already been implemented, although a few features needed workarounds on Enso side to work properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests and improvements for secrets in cloud subdirectories enso-org/enso
2 participants
@radeusgd @jdunkerley