-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a very basic "text editor" widget, a copy of integer widget allowing any text #8823
Comments
Is this meant for text literals and |
Yes, for faster typing of arguments such as column names. |
Ilya Bogdanov reports a new STANDUP for yesterday (2024-01-24): Progress: Starting to work on text input widget for text literals, addressing review comments in PR for numeric input widget. It should be finished by 2024-01-26. |
Ilya Bogdanov reports a new 🔴 DELAY for the provided date (2024-01-26): Summary: There is 3 days delay in implementation of the Add a very basic "text editor" widget, a copy of integer widget allowing any text (#8823) task. 2 days are weekends Delay Cause: An issue with focus handling caused slight delay in preparations of the PR. |
Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-26): Progress: Polished the code and opened a PR. It should be finished by 2024-01-29. |
Ilya Bogdanov reports a new STANDUP for today (2024-01-29): Progress: Addressed review comments. A lot of calls, fixed a small issue in documentation panel, tried reproducing issue with broken project on Mac with no success. It should be finished by 2024-01-29. |
Closes #8823 https://github.com/enso-org/enso/assets/6566674/966576ec-6507-401c-98d3-bd71c2ffc6b2 Adds a basic text widget for text literals. ### Important Notes Several known restrictions: - Separators would always be replaced with single quotation marks. All types of separators in Enso are supported though, and they would be correctly escaped if needed. - Logic for widget selection probably needs refinement (works for text literals and `Text` types, but does not work for `Text | Integer`, for example) - **(!)** There is a very annoying issue when the input field suddenly loses focus, closing the editing mode and discarding any changes. Debugging shows that it happens when we receive an engine update (and probably recreate the node component/widget tree (???)). It requires a separate investigation.
Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-25): Progress: Working on implementation, focus management proved to be a bit more difficult than in case of number input widget. It should be finished by 2024-01-29. |
No description provided.
The text was updated successfully, but these errors were encountered: