Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a very basic "text editor" widget, a copy of integer widget allowing any text #8823

Closed
Frizi opened this issue Jan 22, 2024 · 7 comments · Fixed by #8873
Closed

Add a very basic "text editor" widget, a copy of integer widget allowing any text #8823

Frizi opened this issue Jan 22, 2024 · 7 comments · Fixed by #8873
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request

Comments

@Frizi
Copy link
Contributor

Frizi commented Jan 22, 2024

No description provided.

@Frizi Frizi transferred this issue from enso-org/engine-benchmark-results Jan 22, 2024
@Frizi Frizi added the -gui label Jan 22, 2024
@farmaazon
Copy link
Contributor

Is this meant for text literals and Text type?

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request s-info-needed Status: more information needed from submitter labels Jan 23, 2024
@vitvakatu vitvakatu self-assigned this Jan 23, 2024
@vitvakatu
Copy link
Contributor

Is this meant for text literals and Text type?

Yes, for faster typing of arguments such as column names.

@enso-bot
Copy link

enso-bot bot commented Jan 25, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-01-24):

Progress: Starting to work on text input widget for text literals, addressing review comments in PR for numeric input widget. It should be finished by 2024-01-26.

@vitvakatu vitvakatu removed the s-info-needed Status: more information needed from submitter label Jan 26, 2024
@vitvakatu vitvakatu mentioned this issue Jan 26, 2024
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 29, 2024

Ilya Bogdanov reports a new 🔴 DELAY for the provided date (2024-01-26):

Summary: There is 3 days delay in implementation of the Add a very basic "text editor" widget, a copy of integer widget allowing any text (#8823) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: An issue with focus handling caused slight delay in preparations of the PR.

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-26):

Progress: Polished the code and opened a PR. It should be finished by 2024-01-29.

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-01-29):

Progress: Addressed review comments. A lot of calls, fixed a small issue in documentation panel, tried reproducing issue with broken project on Mac with no success. It should be finished by 2024-01-29.

mwu-tow pushed a commit that referenced this issue Jan 30, 2024
Closes #8823

https://github.com/enso-org/enso/assets/6566674/966576ec-6507-401c-98d3-bd71c2ffc6b2

Adds a basic text widget for text literals. 

### Important Notes

Several known restrictions:
- Separators would always be replaced with single quotation marks. All types of separators in Enso are supported though, and they would be correctly escaped if needed.
- Logic for widget selection probably needs refinement (works for text literals and `Text` types, but does not work for `Text | Integer`, for example)
- **(!)** There is a very annoying issue when the input field suddenly loses focus, closing the editing mode and discarding any changes. Debugging shows that it happens when we receive an engine update (and probably recreate the node component/widget tree (???)). It requires a separate investigation.
@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-25):

Progress: Working on implementation, focus management proved to be a bit more difficult than in case of number input widget. It should be finished by 2024-01-29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants