Text input widget #8873
Merged
Text input widget #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
CI: No changelog needed
vitvakatu
requested review from
Frizi,
farmaazon,
MichaelMauderer and
kazcw
as code owners
farmaazon
reviewed
Jan 29, 2024
Comment on lines
15
to
21
| const editedValue = ref(props.modelValue) | ||
| watch( | ||
| () => props.modelValue, | ||
| (newValue) => { | ||
| editedValue.value = newValue | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Same comment as in NumericInput wouldn't hurt, I think.
app/gui2/src/util/measurement.ts
Outdated
Comment on lines
22
to
24
| /** Helper function to get text width to make sure that labels on the x axis do not overlap, | ||
| * and keeps it readable. */ | ||
| export function getTextWidthByFont(text: string | null | undefined, font: string) { |
There was a problem hiding this comment.
Update docs in this and getTextWidthByFont First, they should differ a bit, second it's no longer used for axes only.
There was a problem hiding this comment.
I always assumed widgets in this directory are a "general-usage" widgets. Now, this one is very specific: for editing Enso text literals (not just any text). So I think it could be merged with WidgetText, or renamed to EnsoTextInputWidget.
There was a problem hiding this comment.
I’m not keen on merging it with WidgetText, at least yet. So I just renamed it.
farmaazon
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #8823
text.editing.mp4
Adds a basic text widget for text literals.
Important Notes
Several known restrictions:
Texttypes, but does not work forText | Integer, for example)Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.