Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set component doesn't work in GUI2 #8884

Closed
Tracked by #8745
AdRiley opened this issue Jan 29, 2024 · 1 comment · Fixed by #8893
Closed
Tracked by #8745

Set component doesn't work in GUI2 #8884

AdRiley opened this issue Jan 29, 2024 · 1 comment · Fixed by #8893
Assignees
Labels
--bug Type: bug -gui p-highest Should be completed ASAP

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 29, 2024

Trying to configure the set component via the drop downs doesn't work:

image

Found in build ide2-enso-win-2024.1.1-nightly.2024.1.29.exe

@AdRiley AdRiley added p-highest Should be completed ASAP --bug Type: bug -gui labels Jan 29, 2024
@AdRiley AdRiley mentioned this issue Jan 29, 2024
@farmaazon farmaazon assigned farmaazon and kazcw and unassigned farmaazon Jan 29, 2024
@kazcw kazcw mentioned this issue Jan 29, 2024
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 30, 2024

Keziah Wesley reports a new STANDUP for today (2024-01-29):

Progress: Implemented automatic parentheses (fixes #8884); moved metadata into AST Y.Js objects (#8237). It should be finished by 2024-01-29.

Next Day: Next day I will be working on the #8238 task. Start on identity-preserving text edits.

@kazcw kazcw linked a pull request Jan 31, 2024 that will close this issue
5 tasks
mwu-tow pushed a commit that referenced this issue Feb 2, 2024
)

- Synchronize Y.Js clients by AST (implements #8237).
- Before committing an edit, insert any parentheses-nodes needed for the concrete syntax to reflect tree structure (fixes #8884).
- Move `externalId` and all node metadata into a Y.Map owned by each `Ast`. This allows including metadata changes in an edit, enables Y.Js merging of changes to different metadata fields, and will enable the use of Y.Js objects in metadata. (Implements #8804.)

### Important Notes

- Metadata is now set and retrieved through accessors on the `Ast` objects.
- Since some metadata edits need to take effect in real time (e.g. node dragging), new lower-overhead APIs (`commitDirect`, `skipTreeRepair`) are provided for careful use in certain cases.
- The client is now bundled as ESM.
- The build script cleans up git-untracked generated files in an outdated location, which fixes lint errors related to `src/generated` that may occur when switching branches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-highest Should be completed ASAP
Projects
Archived in project
3 participants