Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dropdown for already applied argument #8932

Closed
vitvakatu opened this issue Feb 1, 2024 · 6 comments · Fixed by #8983
Closed

No dropdown for already applied argument #8932

vitvakatu opened this issue Feb 1, 2024 · 6 comments · Fixed by #8983
Assignees
Labels
--bug Type: bug -gui
Milestone

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Feb 1, 2024

For the following code:

table.aggregate [Aggregate_Column.GroupBy 'Value']

There is no dropdown for 'Value', even though it exists when no argument is selected there.

@enso-bot
Copy link

enso-bot bot commented Feb 1, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-01-31):

Progress: Debugging the issue with missing dropdown. It should be finished by 2024-02-02.

@enso-bot
Copy link

enso-bot bot commented Feb 1, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-02-01):

Progress: Debugging, found the issue, prepared a hotfix and discussed the proper fix. Adding an arrow for dropdowns. It should be finished by 2024-02-02.

mwu-tow pushed a commit that referenced this issue Feb 2, 2024
Partial fix for #8932 

https://github.com/enso-org/enso/assets/6566674/75a878fb-891b-44fc-bdfd-c3cbb90c9f35

This is not a correct fix, as comparing strings is not what we really want, but it should fix most of use cases.
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@mergify mergify bot closed this as completed in #8983 Feb 12, 2024
mergify bot pushed a commit that referenced this issue Feb 12, 2024
Closes #8932

Now we use a bit more robust mechanism for passing dynamic configuration down the widget tree inside dropdowns, no longer relying on the `label`s used for dropdown items.

Curiously, we still need to use a hotfix implemented earlier, as we won’t have info about the currently selected item otherwise. Highlight for the currently selected item is not crucial as proper dynamic config, so we can leave with the current solution in the meantime.

No visual changes to the IDE, apart from fixed highlight for currently selected item.

# Important Notes
Target branch: #8950, for easier testing.
@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new 🔴 DELAY for the provided date (2024-02-02):

Summary: There is 4 days delay in implementation of the No dropdown for already applied argument (#8932) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: Implementation is complicated, extended the scope with visuals (dropdown arrows) from another task.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-02):

Progress: Implementing a proper fix, opened a PR with the arrow for dropdowns, which should count as part of this task now instead of 8949. It should be finished by 2024-02-06.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-05):

Progress: Implementing dropdown configuration propagation. It should be finished by 2024-02-06.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-06):

Progress: Finished the implementation. Fixed the behavior of selected item. Opened a PR. It should be finished by 2024-02-06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants