Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A quick fix for incorrectly working dropdowns. #8933

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Partial fix for #8932

dropdown-fixed.mp4

This is not a correct fix, as comparing strings is not what we really want, but it should fix most of use cases.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Feb 1, 2024
@vitvakatu vitvakatu self-assigned this Feb 1, 2024
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Feb 2, 2024
@mwu-tow mwu-tow merged commit 45221d9 into develop Feb 2, 2024
24 of 27 checks passed
@mwu-tow mwu-tow deleted the wip/vitvakatu/hotfix-dropdowns branch February 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants