Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render self argument connections as arrows #9064

Closed
2 tasks done
AdRiley opened this issue Feb 14, 2024 · 3 comments · Fixed by #9116
Closed
2 tasks done

Render self argument connections as arrows #9064

AdRiley opened this issue Feb 14, 2024 · 3 comments · Fixed by #9116
Assignees
Labels
-gui p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 14, 2024

Update the self argument connections as per the figma design.

So instead of seeing operator12345

image

we get an arrow

image

Tasks

  1. -gui CI: No changelog needed
    kazcw
  2. -gui CI: No changelog needed
    kazcw
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Feb 14, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 14, 2024
@Frizi Frizi added the p-high Should be completed in the next sprint label Feb 16, 2024
@Frizi
Copy link
Contributor

Frizi commented Feb 16, 2024

Refinement notes:

  • The arrow should appear only in the most obvious case: method call with a "self" argument placed the access chain
  • The icon should become a port to which you can connect a different "self" value
  • The icon should still behave as a drag handler for the node when we are not dragging any connections

@enso-bot
Copy link

enso-bot bot commented Feb 19, 2024

Keziah Wesley reports a new STANDUP for today (2024-02-19):

Progress: Implemented edge-rendering mode for self-arrows. It should be finished by 2024-02-23.

Next Day: Next day I will be working on the #9064 task. Refactoring to enable node icons to be ports.

@enso-bot
Copy link

enso-bot bot commented Feb 21, 2024

Keziah Wesley reports a new STANDUP for today (2024-02-20):

Progress: Finished self-arguments feature. It should be finished by 2024-02-21.

Next Day: Next day I will be working on the #9064 task. Address review, pick something new from backlog.

@kazcw kazcw linked a pull request Feb 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants