Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-argument arrows: New edge rendering mode #9099

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Feb 19, 2024

Pull Request Description

Implement the new edge-rendering mode for #9064. The mode is not used yet, but can be tested by hard-coding targetIsSelfArgument to true.

image
Demo of the new edge mode. Note that when this mode is put into actual use, the arrows will point to the icons.

Important Notes

  • For ease of review, changes have been divided into a preparatory refactor commit and the new functionality.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw self-assigned this Feb 19, 2024
@kazcw kazcw added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Feb 19, 2024
@kazcw kazcw merged commit 01fc65e into develop Feb 21, 2024
28 checks passed
@kazcw kazcw deleted the wip/kw/self-arrows/1-arrow-rendering branch February 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants