Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Browser should not be prepopulated with text and should be connected #9210

Closed
AdRiley opened this issue Feb 28, 2024 · 8 comments · Fixed by #10006
Closed

Component Browser should not be prepopulated with text and should be connected #9210

AdRiley opened this issue Feb 28, 2024 · 8 comments · Fixed by #10006
Assignees
@kazcw
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2024

When adding a new component that is connected to an existing component the component browser should:

  • be connected
  • not be pre-populated with operator123456.

From:

image

To:

image
@AdRiley AdRiley added the -gui label Feb 28, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 28, 2024
@farmaazon
Copy link
Contributor

  1. What if use won't pick any component from list but instead type foo? Should we apply operator123456. before?
  2. What if user instead type some code like + 2 or 2 + 2 or (foo)?

@AdRiley
Copy link
Member Author

AdRiley commented Feb 29, 2024

Yes I think we apply operator123456. before all of those. The operator123456. is implicit because the user created a connected component.

If the user wants a unconnected component they can use the bottom left + icon.

@farmaazon
Copy link
Contributor

Refinement notes:

  • We should replace CB input with codemirror, where the operator12345. will be replaced with WidgetPort (or something, to which we could display a connection). This will be a codemirror decoration.

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints labels Feb 29, 2024
@AdRiley AdRiley removed this from the Beta Release milestone Feb 29, 2024
@farmaazon farmaazon mentioned this issue Mar 7, 2024
Closed
@AdRiley AdRiley added this to the Beta Release milestone Mar 11, 2024
@AdRiley AdRiley removed this from the Beta Release milestone Apr 15, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 13, 2024
@farmaazon
Copy link
Contributor

Update: Let's use Lexical here, not CodeMirror. We don't need the understanding of Enso language immediately (e.g. coloring).

@kazcw kazcw self-assigned this May 15, 2024
@enso-bot enso-bot bot mentioned this issue May 15, 2024
Closed
@kazcw
Copy link
Contributor

kazcw commented May 17, 2024

Update: We decided during standup that we will support the equivalent of removing the dot after typing space.

@enso-bot
Copy link

enso-bot bot commented May 18, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-05-16):

Progress: Decoupled CB Input UI from CB; implemented icon and edge logic. It should be finished by 2024-05-22.

Next Day: Next day I will be working on the #9210 task. Same task.

@enso-bot
Copy link

enso-bot bot commented May 18, 2024

Keziah Wesley reports a new STANDUP for today (2024-05-17):

Progress: Implemented CB text transform and updated tests. It should be finished by 2024-05-22.

Next Day: Next day I will be working on the #9210 task. Address a remaining issue with selections; testing.

@kazcw kazcw mentioned this issue May 20, 2024
Merged
4 tasks
@mergify mergify bot closed this as completed in #10006 May 21, 2024
mergify bot pushed a commit that referenced this issue May 21, 2024
@kazcw
CB self icons (#10006)
1633965 
In the component browser input field, render the source node as an icon instead of its identifier; an edge connects the icon to the source node's output port.

https://github.com/enso-org/enso/assets/1047859/a36a8a55-6717-4887-a72c-2b2eafde4260

Closes #9210.

# Important Notes
- Fix node selection being visible (but glitched) while editing node.
- Fix bug in CB positioning when editing a node at non-default zoom.
- Fix disconnected edge hover allowing self-connection.
- Consolidate some color logic in `nodeColors`.
@enso-bot
Copy link

enso-bot bot commented May 21, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-05-20):

Progress: Finished CB self icons. Configured doc editor to support lists (#10008). Fixed #9963. Fixed a touchpad annoyance (#10007). It should be finished by 2024-05-20.

Next Day: Next day I will be working on the #9831 task. Investigate suggestion db / icons issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Status: 🗄️ Archived
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

CB self icons enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon