Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase setInterval delay in Ydoc test #10055

Merged
merged 1 commit into from
May 23, 2024
Merged

Increase setInterval delay in Ydoc test #10055

merged 1 commit into from
May 23, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 23, 2024

Pull Request Description

The TimersTest.clearTimeout may randomly fail on CI https://github.com/enso-org/enso/actions/runs/9207727907/job/25328411984?pr=10048

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels May 23, 2024
@4e6 4e6 self-assigned this May 23, 2024
JaroslavTulach
JaroslavTulach approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kind of PR that shall not require review, maybe even direct integration to develop branch...

@mergify mergify bot merged commit b27b5ea into develop May 23, 2024
37 of 38 checks passed
@mergify mergify bot deleted the wip/db/fix-flaky-ydoc-test branch May 23, 2024 16:19
MrFlashAccount pushed a commit that referenced this pull request May 25, 2024
@4e6 @MrFlashAccount
Increase setInterval delay in Ydoc test (#10055)
c5b5c45 
The `TimersTest.clearTimeout` may randomly fail on CI https://github.com/enso-org/enso/actions/runs/9207727907/job/25328411984?pr=10048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@Akirathan Akirathan Awaiting requested review from Akirathan

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4e6 @hubertp @JaroslavTulach