Extract Symlinks from Archives #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
suggested changes
May 4, 2021
| @@ -75,5 +75,5 @@ case class UninstallationError(message: String) | |||
| /** Indicates that the required executable was not found. */ | |||
| case class ExecutableNotFoundError(path: Path, name: String) | |||
| extends ComponentsException( | |||
| s"Executable with the name '$name' does not found on $path." | |||
| s"Executable with the name '$name' was not found on $path." | |||
There was a problem hiding this comment.
We have to be careful with log messages like these. Users may have sensitive data in their path and this may leak it. This is probably something we need to think about more broadly, and perhaps have an additional flag alongside the log level that controls whether we log possible PII.
Of course these logs are only on-user-disk, but by the same token we can't expect them to read through the entire log to check if it's okay to send.
iamrecursion
approved these changes
May 4, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Jun 24, 2021
re-create symlinks when extracting archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Changelog:
RuntimeVersionManagerImportant Notes
Checklist
Please include the following checklist in your PR: