Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include namespace in the project manager messages #1820

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Include namespace in the project manager messages #1820

merged 3 commits into from
Jun 25, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Jun 25, 2021

Pull Request Description

The IDE must know the project namespace to work properly with the language server. This includes the necessary data in project manager communications.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement -tooling Category: tooling p-highest Should be completed ASAP labels Jun 25, 2021
@kustosz kustosz self-assigned this Jun 25, 2021
@iamrecursion
Copy link
Contributor

Please make sure that @farmaazon is aware of this for integration with the new namespace stuff in the IDE in the coming week.

@kustosz
Copy link
Contributor Author

kustosz commented Jun 25, 2021

Please make sure that @farmaazon is aware of this for integration with the new namespace stuff in the IDE in the coming week.

The change was requested by @farmaazon :)

@iamrecursion
Copy link
Contributor

Excellent!

@kustosz kustosz merged commit faf4214 into main Jun 25, 2021
@kustosz kustosz deleted the wip/mk/namespace_in_pm branch June 25, 2021 11:09
iamrecursion pushed a commit that referenced this pull request Jul 9, 2021
@kustosz @iamrecursion
Include namespace in the project manager messages (#1820)
3f25bfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@iamrecursion iamrecursion iamrecursion approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
-tooling Category: tooling p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kustosz @iamrecursion @4e6