Colorful Histograms #3153
Merged
Colorful Histograms #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color of histogram bars was incorrectly calculcated from x-axis value, not from y-axis as it should. It is fixed now by swapping x with y. Issue: #2940
A new continuously-colored bar is added to the left of y-axis to visualize color scheme used by the histogram. The width of the bar is fixed and always equals to 5 points. Issue: 2940
As per @wdanilo review
This reverts commit fde7f83.
MichaelMauderer
approved these changes
Nov 11, 2021
wdanilo
approved these changes
Nov 18, 2021
|
@vitvakatu Could you resolve the conflicts, and then we get this merged? |
|
@MichaelMauderer done, again some weird github issues - merge didn't require conflict resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixed coloring of histograms (now it is applied basing on y-axis, not x-axis) and added color legend to the side of histogram.
Resolves #2940
Before: see screenshot in #2940
After:
Important Notes
The position and size of the color legend might not be ideal. It was choosen because of easier implementation and no need to move other elements of the histogram.
Your suggestions are always welcome.
Checklist
Please include the following checklist in your PR: