Data analysts should be able to transform a Table using the rename_columns functions #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
changed the base branch from
develop
to
wip/radeusgd/remove-columns-180994905
Base automatically changed from
wip/radeusgd/remove-columns-180994905
to
develop
February 3, 2022 14:18
jdunkerley
force-pushed
the
wip/jd/rename-columns-181034927
branch
from
9215aaa
to
481f0f5
Compare
radeusgd
reviewed
Feb 8, 2022
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Table_Helpers.enso
Outdated
Show resolved
Hide resolved
jdunkerley
force-pushed
the
wip/jd/rename-columns-181034927
branch
from
1b17985
to
6f626cd
Compare
Align Column_Mapping Add By_Position Separating off the validation for By_Index so can reuse for rename By_Position implemented By_Index implemented Adjusted behaviour following discussion with Ned, so that renames dominate untouched columns. Moving to validation style checks for problems Putting accumulator back Rename work
Tidy of Unique Name Strategy
Tests for Unique Naming Strategy Table rename working
Fix for Table **Must follow up on slice**
jdunkerley
force-pushed
the
wip/jd/rename-columns-181034927
branch
from
bd73d39
to
da3e5f7
Compare
(and associated fixes)
Tests to go...
wdanilo
approved these changes
Feb 10, 2022
4e6
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adding the
rename_columnsfunction to theSystem.Table.Data.TableandSystem.DataBase.Data.Tabletypes.Adding the
use_first_row_as_namesfunction to theSystem.Table.Data.Tabletype.Closes https://www.pivotaltracker.com/story/show/181034927
Closes https://www.pivotaltracker.com/story/show/181034968
Important Notes
Implemented a Range.Find utility function to help with this.
Some minor issues added to bugs to investigate list.
Checklist
Please include the following checklist in your PR: