Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Mode for Graph Editor #3264

Merged
merged 10 commits into from Feb 14, 2022
Merged

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Feb 10, 2022

Pull Request Description

Task link.

This PR adds an implementation of Debug Mode for Graph Editor. In this mode, a few special actions are available (they are marked with debug_mode condition in the Graph Editor shortcuts list). In the future, we would add more such actions (for example, node zooming with levels more than 1.0 will be available in debug mode only).

Debug Mode is toggled by pressing ctrl + shift + d key combination. The task mentioned ctrl + shift + alt + d, but apparently, such a combination does not work for me (probably hardware reasons).

A label on top of the screen signals that debug mode was enabled/disabled.

2022-02-10.14-39-03.mp4

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@vitvakatu vitvakatu self-assigned this Feb 10, 2022
@vitvakatu vitvakatu marked this pull request as ready for review February 10, 2022 12:00
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the Popup constructor a little, so it will be consistent with other visual components we have (see comments for details).

CHANGELOG.md Outdated Show resolved Hide resolved
app/gui/view/src/debug_mode_popup.rs Outdated Show resolved Hide resolved
app/gui/view/src/debug_mode_popup.rs Outdated Show resolved Hide resolved
@mwu-tow mwu-tow merged commit 03e105d into develop Feb 14, 2022
@mwu-tow mwu-tow deleted the wip/vitvakatu/debug-mode-181181159 branch February 14, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants