-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Mode for Graph Editor #3264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
MichaelMauderer,
wdanilo,
farmaazon and
mwu-tow
as code owners
February 10, 2022 12:00
wdanilo
approved these changes
Feb 10, 2022
farmaazon
requested changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor the Popup constructor a little, so it will be consistent with other visual components we have (see comments for details).
farmaazon
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Task link.
This PR adds an implementation of Debug Mode for Graph Editor. In this mode, a few special actions are available (they are marked with
debug_mode
condition in the Graph Editor shortcuts list). In the future, we would add more such actions (for example, node zooming with levels more than 1.0 will be available in debug mode only).Debug Mode is toggled by pressing
ctrl + shift + d
key combination. The task mentionedctrl + shift + alt + d
, but apparently, such a combination does not work for me (probably hardware reasons).A label on top of the screen signals that debug mode was enabled/disabled.
2022-02-10.14-39-03.mp4
Important Notes
Checklist
Please include the following checklist in your PR: