New Text.insert function #3311
Merged
New Text.insert function #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Good general shape, but the current implementation seems to insert at codepoint positions whereas we use grapheme-cluster based indexing everywhere.
Great that there are tests for edge cases like inserting at the end of the string and just after it. But some more tests should be added to test the behaviour in presence of grapheme clusters that consist of multiple codepoints.
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
Deal with grapheme cluster bounderies correctly. Updated docs.
hubertp
force-pushed
the
wip/hubert/text-insert-181265049
branch
from
80eec62
to
0d2b1b7
Compare
radeusgd
approved these changes
Mar 3, 2022
Co-authored-by: Radosław Waśko <wasko.radek@gmail.com>
Addressed the remaining PR review comments
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The change adds
Text.insertfunction to allow for adding a section of text into another at a specified position.Implements https://www.pivotaltracker.com/n/projects/2539304.
Checklist
Please include the following checklist in your PR:
./run distand./run watch.