-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement of newly opened Component Browser when nodes are selected #3361
Merged
mergify
merged 28 commits into
develop
from
wip/akavel/cb-placement-nodes-selected-180887079
Mar 31, 2022
Merged
Placement of newly opened Component Browser when nodes are selected #3361
mergify
merged 28 commits into
develop
from
wip/akavel/cb-placement-nodes-selected-180887079
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement-nodes-selected-180887079
…ement-nodes-selected-180887079
wdanilo
approved these changes
Mar 28, 2022
app/gui/view/graph-editor/src/lib.rs
Outdated
/// "add_node" FRP event was emitted. | ||
AddNodeEvent, | ||
/// "start_node_creation" FRP event was emitted. | ||
StartCreationEvent, | ||
/// "start_node_creation_from_port" FRP event was emitted. | ||
#[allow(missing_docs)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this to the whole enum instead - will be clearner
(Process note: the code-review is now Approved, therefore the PR is waiting for an Acceptance/QA Review by @vitvakatu on Task https://www.pivotaltracker.com/story/show/180887079 before merge.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When a new node is created with the TAB key or by clicking the
(+)
on-screen button while multiple nodes are selected, place the new node below all the selected nodes. (Previously, the new node was placed below the node that was selected earliest.)Additionally, when placing a new node below an existing non-error node with a visualization enabled, place the new node below the visualization. (Previously, the new node was placed to the left of the visualization.)
https://www.pivotaltracker.com/story/show/180887079
Visuals
The following screencast demonstrates the feature on various arrangements of selected nodes, with visualization enabled and disabled.
Screen.Recording.2022-03-24.at.18.02.25.mov
The following screencast demonstrates that new nodes created by double-clicking an output port of a node with visualization enabled are now placed below the visualization:
Screen.Recording.2022-03-25.at.11.52.35.mov
Important Notes
new_node_position
);free_place_finder
module was made a submodule of thenew_node_position
module, due to the latter being its only user.Checklist
Please include the following checklist in your PR:
./run dist
and./run watch
.