Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement of newly opened Component Browser when nodes are selected #3361

Merged
merged 28 commits into from
Mar 31, 2022

Conversation

akavel
Copy link
Contributor

@akavel akavel commented Mar 24, 2022

Pull Request Description

When a new node is created with the TAB key or by clicking the (+) on-screen button while multiple nodes are selected, place the new node below all the selected nodes. (Previously, the new node was placed below the node that was selected earliest.)

Additionally, when placing a new node below an existing non-error node with a visualization enabled, place the new node below the visualization. (Previously, the new node was placed to the left of the visualization.)

https://www.pivotaltracker.com/story/show/180887079

Visuals

The following screencast demonstrates the feature on various arrangements of selected nodes, with visualization enabled and disabled.

Screen.Recording.2022-03-24.at.18.02.25.mov

The following screencast demonstrates that new nodes created by double-clicking an output port of a node with visualization enabled are now placed below the visualization:

Screen.Recording.2022-03-25.at.11.52.35.mov

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@akavel akavel marked this pull request as ready for review March 25, 2022 11:27
/// "add_node" FRP event was emitted.
AddNodeEvent,
/// "start_node_creation" FRP event was emitted.
StartCreationEvent,
/// "start_node_creation_from_port" FRP event was emitted.
#[allow(missing_docs)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to the whole enum instead - will be clearner

@akavel
Copy link
Contributor Author

akavel commented Mar 28, 2022

(Process note: the code-review is now Approved, therefore the PR is waiting for an Acceptance/QA Review by @vitvakatu on Task https://www.pivotaltracker.com/story/show/180887079 before merge.)

@akavel akavel requested review from 4e6 and mwu-tow as code owners March 31, 2022 15:23
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Mar 31, 2022
@mergify mergify bot merged commit 3c5f8d7 into develop Mar 31, 2022
@mergify mergify bot deleted the wip/akavel/cb-placement-nodes-selected-180887079 branch March 31, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants