-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement of newly opened Component Browser when nodes are selected #3361
Merged
mergify
merged 28 commits into
develop
from
wip/akavel/cb-placement-nodes-selected-180887079
Mar 31, 2022
Merged
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5c974d4
refactoring
akavel 5a4fc09
WIP under_selection, under_position
akavel b16db4e
below bbox
akavel 5954621
(cargo fmt)
akavel 798a063
add doc for node_bounding_box()
akavel 0b8a5a1
rename to below_line_and_pushed_left
akavel 46eb89c
more comments & naming
akavel 71c8061
fix
akavel 59bf387
rename left_aligned_below_line
akavel 46a2d02
add doc for under_selection
akavel 2eaca07
refactor under_selection
akavel 0ce15a8
Merge remote-tracking branch 'origin/develop' into wip/akavel/cb-plac…
akavel 28b2bf6
fix clippy & rename a var
akavel c3a5e96
Merge remote-tracking branch 'origin/develop' into wip/akavel/cb-plac…
akavel 9a7872f
add changelog
akavel db8e43c
mention visualizations alignment in changelog
akavel e32861e
tweak phrasing in changelog
akavel 3db4c7f
another rephrase
akavel 8163e2b
rephrase the fix changelogl
akavel 845efdf
use deref
akavel 21cb410
WIP tweaks
akavel fad6972
add a var
akavel 8f35def
rename under_selected_nodes()
akavel 2aad732
review: move missing_docs to enum
akavel bba4ab3
Implement integration tests
vitvakatu 15a8df3
fix unused variables & formatting
vitvakatu 3190b09
Merge branch 'develop' into wip/akavel/cb-placement-nodes-selected-18…
vitvakatu d82ed2c
a tweaks to comments missed in merge
akavel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this to the whole enum instead - will be clearner